From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Weiny, Ira" <ira.weiny@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"Biesek, Michal" <michal.biesek@intel.com>
Subject: Re: [ndctl PATCH] libdaxctl: fix memory leaks with daxctl_memory objects
Date: Thu, 3 Oct 2019 00:01:24 +0000 [thread overview]
Message-ID: <796dc27db614dfd931b2568162f5f885195ba408.camel@intel.com> (raw)
In-Reply-To: <20191001231909.GA11607@iweiny-DESK2.sc.intel.com>
On Tue, 2019-10-01 at 16:19 -0700, Ira Weiny wrote:
>
> > diff --git a/daxctl/lib/libdaxctl.c b/daxctl/lib/libdaxctl.c
> > index 8abfd64..639224c 100644
> > --- a/daxctl/lib/libdaxctl.c
> > +++ b/daxctl/lib/libdaxctl.c
> > @@ -204,8 +204,9 @@ DAXCTL_EXPORT void daxctl_region_get_uuid(struct daxctl_region *region, uuid_t u
> >
> > static void free_mem(struct daxctl_dev *dev)
> > {
> > - if (dev && dev->mem) {
> > + if (dev->mem) {
>
> There is a comment in daxctl_dev_disable() which says:
>
> /* If there is a memory object, first free that */
>
> I'm 100% sure that dev can't be NULL there. So that comment no longer applies.
>
> May want to remove that comment.
>
Hm, I'm not sure I follow.
Yes, dev can't be null there, but 'mem' can me. Hence the comment saying
if /mem/ is present, free it.
The check in free_mem() only checks for non-NULL mem too.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2019-10-03 0:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 17:37 [ndctl PATCH] libdaxctl: fix memory leaks with daxctl_memory objects Vishal Verma
2019-10-01 23:19 ` Ira Weiny
2019-10-03 0:01 ` Verma, Vishal L [this message]
2019-10-03 15:41 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=796dc27db614dfd931b2568162f5f885195ba408.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=michal.biesek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).