From: Jens Axboe <axboe@kernel.dk>
To: Matteo Croce <mcroce@redhat.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvdimm@lists.01.org, linux-bcache@vger.kernel.org,
linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org,
linux-nfs@vger.kernel.org
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Anna Schumaker <anna.schumaker@netapp.com>,
Song Liu <song@kernel.org>,
Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
Subject: Re: [PATCH v3] block: refactor duplicated macros
Date: Wed, 11 Mar 2020 06:58:39 -0600 [thread overview]
Message-ID: <7e03d359-f199-29d8-a75f-20c4b7ff3031@kernel.dk> (raw)
In-Reply-To: <20200311002254.121365-1-mcroce@redhat.com>
On 3/10/20 6:22 PM, Matteo Croce wrote:
> The macros PAGE_SECTORS, PAGE_SECTORS_SHIFT and SECTOR_MASK are defined
> several times in different flavours across the whole tree.
> Define them just once in a common header.
>
> While at it, replace replace "PAGE_SHIFT - 9" with "PAGE_SECTORS_SHIFT" too
> and rename SECTOR_MASK to PAGE_SECTORS_MASK.
Applied, thanks.
--
Jens Axboe
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
prev parent reply other threads:[~2020-03-11 12:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 0:22 [PATCH v3] block: refactor duplicated macros Matteo Croce
2020-03-11 2:42 ` Martin K. Petersen
2020-03-11 11:20 ` Coly Li
2020-03-11 12:58 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e03d359-f199-29d8-a75f-20c4b7ff3031@kernel.dk \
--to=axboe@kernel.dk \
--cc=anna.schumaker@netapp.com \
--cc=guoqing.jiang@cloud.ionos.com \
--cc=jejb@linux.ibm.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mcroce@redhat.com \
--cc=song@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).