From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B4F4C4CEC5 for ; Fri, 13 Sep 2019 20:33:22 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9E7D20830 for ; Fri, 13 Sep 2019 20:33:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9E7D20830 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 7F66D202EA405; Fri, 13 Sep 2019 13:33:13 -0700 (PDT) Received-SPF: None (no SPF record) identity=mailfrom; client-ip=216.40.44.190; helo=smtprelay.hostedemail.com; envelope-from=joe@perches.com; receiver=linux-nvdimm@lists.01.org Received: from smtprelay.hostedemail.com (smtprelay0190.hostedemail.com [216.40.44.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A82C6202EA3ED for ; Fri, 13 Sep 2019 13:33:11 -0700 (PDT) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id F12BD18224D86; Fri, 13 Sep 2019 20:33:17 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: tub87_73cd010985e19 X-Filterd-Recvd-Size: 3342 Received: from XPS-9350.home (unknown [47.151.152.152]) (Authenticated sender: joe@perches.com) by omf10.hostedemail.com (Postfix) with ESMTPA; Fri, 13 Sep 2019 20:33:15 +0000 (UTC) Message-ID: <8be2df9936fb405ffaee75d6e24bbac0e938a653.camel@perches.com> Subject: Re: [Ksummit-discuss] [PATCH v2 0/3] Maintainer Entry Profiles From: Joe Perches To: Mauro Carvalho Chehab Date: Fri, 13 Sep 2019 13:33:14 -0700 In-Reply-To: <20190913161731.6e3405a3@coco.lan> References: <156821692280.2951081.18036584954940423225.stgit@dwillia2-desk3.amr.corp.intel.com> <6fe45562-9493-25cf-afdb-6c0e702a49b4@acm.org> <44c08faf43fa77fb271f8dbb579079fb09007716.camel@perches.com> <74984dc0-d5e4-f272-34b9-9a78619d5a83@acm.org> <4299c79e33f22e237e42515ea436f187d8beb32e.camel@perches.com> <78f67ee934f167b433517da81c6a0d3f35c4b123.camel@perches.com> <20190913161731.6e3405a3@coco.lan> User-Agent: Evolution 3.32.1-2 MIME-Version: 1.0 X-BeenThere: linux-nvdimm@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Linux-nvdimm developer list." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bart Van Assche , ksummit , linux-nvdimm , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Rob Herring , Dmitry Vyukov , Steve French , "Tobin C. Harding" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" On Fri, 2019-09-13 at 16:17 -0300, Mauro Carvalho Chehab wrote: > Em Fri, 13 Sep 2019 11:42:38 -0700 > Joe Perches escreveu: [] > > Just fyi: for an x86-64 defconfig with gcc 8.3 > > > > $ { make clean ; make defconfig ; make -j4 W=1 ; } > make.log 2>&1 > > > > There are ~300 W=1 for non kernel-doc -W warnings. > > > > $ grep -i -P -oh '\[\-W[\w\-]+\]' make.log |sort | uniq -c | sort -rn > > 163 [-Wmissing-prototypes] > > 69 [-Wunused-but-set-variable] > > 16 [-Wempty-body] > > 10 [-Wtype-limits] > > 6 [-Woverride-init] > > 2 [-Wstringop-truncation] > > 2 [-Wcast-function-type] > > 1 [-Wunused-but-set-parameter] > > On my eyes, it doesn't sound too much. In general, I agree and most of these are pretty trivial to remove. It'd just take some time to remove most of the missing-prototypes and unused-but-set warnings before being able to enable the warnings at the default W=0. > I suspect that, > with gcc-9, it should produce more warnings, though. It doesn't though. At least not so far as I can tell. gcc-9.1 produces the same output. $ { make clean ; make defconfig ; make CC=/usr/bin/gcc-9 -j4 W=1 V=1 ; } > make_gcc9.log 2>&1 $ grep -i -P -oh '\[\-W[\w\-]+\]' make_gcc9.log | sort | uniq -c | sort -rn 163 [-Wmissing-prototypes] 69 [-Wunused-but-set-variable] 16 [-Wempty-body] 10 [-Wtype-limits] 6 [-Woverride-init] 2 [-Wstringop-truncation] 2 [-Wcast-function-type] 1 [-Wunused-but-set-parameter] _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm