linux-nvdimm.lists.01.org archive mirror
 help / color / mirror / Atom feed
From: Coly Li <colyli@suse.de>
To: John Pittman <jpittman@redhat.com>
Cc: linux-nvdimm@lists.01.org, dm-devel@redhat.com,
	Adrian Huang <ahuang12@lenovo.com>, Jan Kara <jack@suse.com>,
	Mike Snitzer <snitzer@redhat.com>,
	Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Subject: Re: [PATCH] dax: fix for do not print error message for non-persistent memory block device
Date: Fri, 11 Sep 2020 08:54:46 +0800	[thread overview]
Message-ID: <92b65cc3-37b6-d038-148a-a32db682830b@suse.de> (raw)
In-Reply-To: <CA+RJvhxBHriCuJhm-D8NvJRe3h2MLM+ZMFgjeJjrRPerMRLvdg@mail.gmail.com>

On 2020/9/11 04:29, John Pittman wrote:
> But it should be moved prior to the two bdev_dax_pgoff() checks right?
>  Else a misaligned partition on a dax unsupported block device can
> print the below messages.
> 
> kernel: sda1: error: unaligned partition for dax
> kernel: sda2: error: unaligned partition for dax
> kernel: sda3: error: unaligned partition for dax
> 

Aha, yes you are right, I agree with you.

Coly Li


> Reviewed-by: John Pittman <jpittman@redhat.com>
> 
> On Thu, Sep 3, 2020 at 12:12 PM Coly Li <colyli@suse.de> wrote:
>>
>> On 2020/9/4 00:06, Ira Weiny wrote:
>>> On Thu, Sep 03, 2020 at 07:55:49PM +0800, Coly Li wrote:
>>>> When calling __generic_fsdax_supported(), a dax-unsupported device may
>>>> not have dax_dev as NULL, e.g. the dax related code block is not enabled
>>>> by Kconfig.
>>>>
>>>> Therefore in __generic_fsdax_supported(), to check whether a device
>>>> supports DAX or not, the following order should be performed,
>>>> - If dax_dev pointer is NULL, it means the device driver explicitly
>>>>   announce it doesn't support DAX. Then it is OK to directly return
>>>>   false from __generic_fsdax_supported().
>>>> - If dax_dev pointer is NOT NULL, it might be because the driver doesn't
>>>>   support DAX and not explicitly initialize related data structure. Then
>>>>   bdev_dax_supported() should be called for further check.
>>>>
>>>> IMHO if device driver desn't explicitly set its dax_dev pointer to NULL,
>>>> this is not a bug. Calling bdev_dax_supported() makes sure they can be
>>>> recognized as dax-unsupported eventually.
>>>>
>>>> This patch does the following change for the above purpose,
>>>>     -       if (!dax_dev && !bdev_dax_supported(bdev, blocksize)) {
>>>>     +       if (!dax_dev || !bdev_dax_supported(bdev, blocksize)) {
>>>>
>>>>
>>>> Fixes: c2affe920b0e ("dax: do not print error message for non-persistent memory block device")
>>>> Signed-off-by: Coly Li <colyli@suse.de>
>>>
>>> I hate to do this because I realize this is a bug which people really need
>>> fixed.
>>>
>>> However, shouldn't we also check (!dax_dev || !bdev_dax_supported()) as the
>>> _first_ check in __generic_fsdax_supported()?
>>>
>>> It seems like the other pr_info's could also be called when DAX is not
>>> supported and we probably don't want them to be?
>>>
>>> Perhaps that should be a follow on patch though.  So...
>>
>> I am not author of c2affe920b0e, but I guess it was because
>> bdev_dax_supported() needed blocksize, so blocksize should pass previous
>> checks firstly to make sure bdev_dax_supported() has a correct blocksize
>> to check.
>>
>>>
>>> As a direct fix to c2affe920b0e
>>>
>>> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
>>
>> Thanks.
>>
>> Coly Li
>>
[snipped]
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

      reply	other threads:[~2020-09-11  0:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03 11:55 Coly Li
2020-09-03 15:26 ` [External] " Adrian Huang12
2020-09-03 16:06 ` Ira Weiny
2020-09-03 16:12   ` Coly Li
2020-09-10 20:29     ` John Pittman
2020-09-11  0:54       ` Coly Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92b65cc3-37b6-d038-148a-a32db682830b@suse.de \
    --to=colyli@suse.de \
    --cc=ahuang12@lenovo.com \
    --cc=dm-devel@redhat.com \
    --cc=jack@suse.com \
    --cc=jpittman@redhat.com \
    --cc=linux-nvdimm@lists.01.org \
    --cc=pankaj.gupta.linux@gmail.com \
    --cc=snitzer@redhat.com \
    --subject='Re: [PATCH] dax: fix for do not print error message for non-persistent memory block device' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox