From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brendan Higgins Subject: Re: [RFC v3 07/19] kunit: test: add initial tests Date: Mon, 3 Dec 2018 15:26:26 -0800 Message-ID: References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-8-brendanhiggins@google.com> <20181130034001.GM18410@garbanzo.do-not-panic.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20181130034001.GM18410@garbanzo.do-not-panic.com> Sender: linux-kernel-owner@vger.kernel.org To: mcgrof@kernel.org Cc: Greg KH , Kees Cook , shuah@kernel.org, Joel Stanley , mpe@ellerman.id.au, joe@perches.com, brakmo@fb.com, rostedt@goodmis.org, Tim.Bird@sony.com, khilman@baylibre.com, Julia Lawall , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Linux Kernel Mailing List , jdike@addtoit.com, richard@nod.at, linux-um@lists.infradead.org, Daniel Vetter , dri-devel@lists.freedesktop.org, Rob Herring , dan.j.williams@intel.com, linux-nvdimm@lists.01.org, kieran.bingham@ideasonboard.com, Frank Rowand , Knut Omang List-Id: linux-nvdimm@lists.01.org On Thu, Nov 29, 2018 at 7:40 PM Luis Chamberlain wrote: > > On Wed, Nov 28, 2018 at 11:36:24AM -0800, Brendan Higgins wrote: > > Add a test for string stream along with a simpler example. > > > > Signed-off-by: Brendan Higgins > > --- > > kunit/Kconfig | 12 ++++++ > > kunit/Makefile | 4 ++ > > kunit/example-test.c | 88 ++++++++++++++++++++++++++++++++++++++ > > BTW if you need another more concrete but very simple example I think it > may be possible to port tools/testing/selftests/sysctl/sysctl.sh + > lib/test_sysctl.c into a kunit test. Correct me if I'm wrong. I think that is pretty doable. I don't know that I want to shoot for that on the next revision. But I can definitely do it in a later revision, or a later patchset, unless you would strongly prefer it now, that is. > > I think that would show the differences clearly between selftests and > kunit as well. True. Maybe a good thing to shoot for once the DT tests are in order?