From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2078CA9ED0 for ; Mon, 4 Nov 2019 03:12:05 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B570A218BA for ; Mon, 4 Nov 2019 03:12:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="bllT6wAY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B570A218BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=socionext.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from new-ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 688BD100EA521; Sun, 3 Nov 2019 19:14:59 -0800 (PST) Received-SPF: Softfail (mailfrom) identity=mailfrom; client-ip=210.131.2.82; helo=conssluserg-03.nifty.com; envelope-from=yamada.masahiro@socionext.com; receiver= Received: from conssluserg-03.nifty.com (conssluserg-03.nifty.com [210.131.2.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3CFF9100EA63E for ; Sun, 3 Nov 2019 19:14:56 -0800 (PST) Received: from mail-ua1-f45.google.com (mail-ua1-f45.google.com [209.85.222.45]) (authenticated) by conssluserg-03.nifty.com with ESMTP id xA43BhGB010058 for ; Mon, 4 Nov 2019 12:11:43 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com xA43BhGB010058 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1572837103; bh=vMxuYwRHws4tNFRGpfPUy5dZwjFqOGxlu03uplhO42I=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bllT6wAYcQvHAnXftO20d2k8LR0rwzuLOFlRzWlzn3UwX2BQxfWA7TlHRRbdsJz/T u3gz0HN+navs80R3Wt64OHlN6KWtKB8XO7/sxf0RP9iIYgGA3gUKtbwyjDKlqOXoMf APr/o3Zr3Y6PVGf+lXrTKwqrslL7XrBKazrs4+3KKi5TFOfCj/0FtHHlItiu2n7Kqf W7e/KUBZm0r5zAj1UHGP8vqt4dGaZJ6/AyogYUXuSiq3sm+Hq8oxrn4sqpBQXnEKbZ JknZGSdRdjzxsS55MbX6H6CoWTgZE6Y1xf/jVpYfLdG7TJt6x8beF3+cvSc1jOUDza s0AXehi9h8y4g== X-Nifty-SrcIP: [209.85.222.45] Received: by mail-ua1-f45.google.com with SMTP id k11so1852945ual.10 for ; Sun, 03 Nov 2019 19:11:43 -0800 (PST) X-Gm-Message-State: APjAAAU4drX0aquUJA1heTl2kxiOOXbu8+JMld+w0wwA6Na9q/pGzKD5 V8s/bqdUMPI5seW/1AAbgAsWN4uGYNbYy5OOEYE= X-Google-Smtp-Source: APXvYqyE0nGV98neToXAe5hLXzbDObfhFlg/QKkxKcBsziWl3jP01hIXqHPwXSYx8xzJ5vABi98f/kqIE5zvSf0Ea7U= X-Received: by 2002:ab0:3395:: with SMTP id y21mr3558264uap.25.1572837102044; Sun, 03 Nov 2019 19:11:42 -0800 (PST) MIME-Version: 1.0 References: <20191003102915.28301-1-yamada.masahiro@socionext.com> <20191003102915.28301-4-yamada.masahiro@socionext.com> In-Reply-To: From: Masahiro Yamada Date: Mon, 4 Nov 2019 12:11:06 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/4] modpost: do not set ->preloaded for symbols from Module.symvers To: Jeff Moyer Message-ID-Hash: RSG3ESESGHDCUHL4XNLX2QTJ4PBEKLOM X-Message-ID-Hash: RSG3ESESGHDCUHL4XNLX2QTJ4PBEKLOM X-MailFrom: yamada.masahiro@socionext.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: Linux Kbuild mailing list , Sam Ravnborg , Michal Marek , Linux Kernel Mailing List , linux-nvdimm X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sat, Nov 2, 2019 at 3:52 AM Jeff Moyer wrote: > > Masahiro Yamada writes: > > > On Fri, Nov 1, 2019 at 1:51 AM Jeff Moyer wrote: > >> > >> Masahiro Yamada writes: > >> > >> > Now that there is no overwrap between symbols from ELF files and > >> > ones from Module.symvers. > >> > > >> > So, the 'exported twice' warning should be reported irrespective > >> > of where the symbol in question came from. Only the exceptional case > >> > is when __crc_ symbol appears before __ksymtab_. This > >> > typically occurs for EXPORT_SYMBOL in .S files. > >> > >> Hi, Masahiro, > >> > >> After apply this patch, I get the following modpost warnings when doing: > >> > >> $ make M=tools/tesing/nvdimm > >> ... > >> Building modules, stage 2. > >> MODPOST 12 modules > >> WARNING: tools/testing/nvdimm/libnvdimm: 'nvdimm_bus_lock' exported > >> twice. Previous export was in drivers/nvdimm/libnvdimm.ko > >> WARNING: tools/testing/nvdimm/libnvdimm: 'nvdimm_bus_unlock' > >> exported twice. Previous export was in drivers/nvdimm/libnvdimm.ko > >> WARNING: tools/testing/nvdimm/libnvdimm: 'is_nvdimm_bus_locked' > >> exported twice. Previous export was in drivers/nvdimm/libnvdimm.ko > >> WARNING: tools/testing/nvdimm/libnvdimm: 'devm_nvdimm_memremap' > >> exported twice. Previous export was in drivers/nvdimm/libnvdimm.ko > >> WARNING: tools/testing/nvdimm/libnvdimm: 'nd_fletcher64' exported twice. Previous export was in drivers/nvdimm/libnvdimm.ko > >> WARNING: tools/testing/nvdimm/libnvdimm: 'to_nd_desc' exported twice. Previous export was in drivers/nvdimm/libnvdimm.ko > >> WARNING: tools/testing/nvdimm/libnvdimm: 'to_nvdimm_bus_dev' > >> exported twice. Previous export was in drivers/nvdimm/libnvdimm.ko > >> ... > >> > >> There are a lot of these warnings. :) > > > > These warnings are correct since > > drivers/nvdimm/Makefile and > > tools/testing/nvdimm/Kbuild > > compile the same files. > > Yeah, but that's by design. Is there a way to silence these warnings? > > -Jeff > "rm -f Module.symvers; make M=tools/testing/nvdimm" ? I'd like the _design_ fixed though. -- Best Regards Masahiro Yamada _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org