From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F17DE21106F21 for ; Fri, 30 Nov 2018 06:05:46 -0800 (PST) Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 974CA21508 for ; Fri, 30 Nov 2018 14:05:46 +0000 (UTC) Received: by mail-qt1-f169.google.com with SMTP id d19so5964423qtq.9 for ; Fri, 30 Nov 2018 06:05:46 -0800 (PST) MIME-Version: 1.0 References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-7-brendanhiggins@google.com> <20181130033704.GL18410@garbanzo.do-not-panic.com> In-Reply-To: <20181130033704.GL18410@garbanzo.do-not-panic.com> From: Rob Herring Date: Fri, 30 Nov 2018 08:05:34 -0600 Message-ID: Subject: Re: [RFC v3 06/19] arch: um: enable running kunit from User Mode Linux List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Luis R. Rodriguez" Cc: brakmo@fb.com, Brendan Higgins , dri-devel , linux-kselftest@vger.kernel.org, shuah@kernel.org, Frank Rowand , linux-nvdimm , Richard Weinberger , knut.omang@oracle.com, Kieran Bingham , Joel Stanley , "Bird, Timothy" , Jeff Dike , Kees Cook , linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , kunit-dev@googlegroups.com, Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Daniel Vetter , Michael Ellerman , Joe Perches , Kevin Hilman List-ID: On Thu, Nov 29, 2018 at 9:37 PM Luis Chamberlain wrote: > > On Wed, Nov 28, 2018 at 03:26:03PM -0600, Rob Herring wrote: > > On Wed, Nov 28, 2018 at 1:37 PM Brendan Higgins > > wrote: > > > > > > Make minimum number of changes outside of the KUnit directories for > > > KUnit to build and run using UML. > > > > There's nothing in this patch limiting this to UML. > > Not that one, but the abort thing segv thing is, eventually. > To support other architectures we'd need to make a wrapper to that > hack which Brendan added, and then allow each os to implement > its own call, and add an asm-generic helper. I've not looked into why this is needed, but can't you make the abort support optional and arches can select it when they support it. At least before, the DT unittests didn't need this to run and shouldn't depend on it after converting to kunit. Rob _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm