From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AB8FECDE20 for ; Thu, 12 Sep 2019 08:42:22 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D26C520CC7 for ; Thu, 12 Sep 2019 08:42:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HQvte52r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D26C520CC7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 23751202E2913; Thu, 12 Sep 2019 01:42:25 -0700 (PDT) Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::143; helo=mail-lf1-x143.google.com; envelope-from=miguel.ojeda.sandonis@gmail.com; receiver=linux-nvdimm@lists.01.org Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 51E84202E2903 for ; Thu, 12 Sep 2019 01:42:23 -0700 (PDT) Received: by mail-lf1-x143.google.com with SMTP id c195so3766216lfg.9 for ; Thu, 12 Sep 2019 01:42:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lNrIuUYLDbT7zQ5324Ye/I2/Q3u9VnMzuPI9RQmmH+s=; b=HQvte52rfMzXkfmg2dy9fX6VpDW3IFfdlGC05XQ8K1w8RM25pVju8tCDde4KUH0v1a 1kcdT7UH/73YhhPccKsaGWDyC+Sz+Wb6IX/AHz34Gb0cW2pCuGQRxZhr8jDVO1REPKTg jwEpA+OPl7mOutzaxAJv2kNWbY5ouhp4RVMwiy22nCjmfGZ+3EozFEdOLX9t+9uGjz3t bBEXwt2yJqGwzYLFaPWKmr6RdcKpM7iziqyRJYi127B5fZCPWJI/JZSJ0wUocRLM5+dS Gc+Gp17oJ9b/iyPdk67fWEsZUWN8K4JROeX14wCj6dt/srxxNI6pKTv+Ztoedr/7VPPN Ba9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lNrIuUYLDbT7zQ5324Ye/I2/Q3u9VnMzuPI9RQmmH+s=; b=HpOubqaOYMTHYJruWg8zweA2xiDf7ftlf98UGCiGg0cHibmupP1ZKk8QW9DqKQ2p88 mE1MxR1yxOPVX6MYBWNGEMvVRIPEMbFH8VSUZo9P925Jv1Lp3Rdt9/oJAUX1rtcd/Crh itvDdrsgCcR6deY3bQ3cnsi5BjXqly6O0nAGqoikYJd6tV1CHFjU4DX4DrKa29YjnTVC Bwvd0u/Le6DMaCa2d207pY1ZYttIPLOags182SdiB3USLj/zMFh7TdJkMqnTFoL6Tb1D 2tst4EDzrrY0i7y6i3EMIJXxaLi8MwRuyaJURGnZEX9olGkWX0KNN6rZK/Uodi5ucBjU QsAg== X-Gm-Message-State: APjAAAUwifhfKJ2Rrlk/EEvwRSCEP2wy7ej7UQD9W5V31DvNhEdQAtLE QB593ZRynkHgjf5VZrVjtd2mDJ8rmi4nksV/hYU= X-Google-Smtp-Source: APXvYqxyEQdbpMlCuAav1TG4x6BjkXais5Z79dXqr0CkWkZVoUFV3EnetqKauoIdCFU9Ic5EJVQo610gutjyqWbL3VU= X-Received: by 2002:ac2:4351:: with SMTP id o17mr1127056lfl.131.1568277737781; Thu, 12 Sep 2019 01:42:17 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Miguel Ojeda Date: Thu, 12 Sep 2019 10:42:06 +0200 Message-ID: Subject: Re: [PATCH 00/13] nvdimm: Use more common kernel coding style To: Joe Perches X-BeenThere: linux-nvdimm@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Linux-nvdimm developer list." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-nvdimm , Linux Kernel Mailing List , Dan Carpenter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" On Thu, Sep 12, 2019 at 10:15 AM Joe Perches wrote: > > I am adding Miguel Ojeda to the cc's. Thanks Joe! > Of course you are welcome to try it, but I believe that > clang-format doesn't work all that well yet. > > It's more a work in progress rather than a "standard". > > I believe you'll find that the patch series I sent > ends up with a rather more typical kernel style. > > I suggest you try to apply the series I sent and then > run clang-format on that and see the differences. Indeed, it is not there just yet. There are a few differences w.r.t. the kernel style that aren't supported yet. However, for block/batch conversions, it is very useful. Luckily, one of the biggest ones (the consecutive macros alignment, and we have a lot of them given this is C and a kernel) is going away with LLVM 9 which is about to be released next week. > Ideally one day, something tool like clang-format > might be locally applied by every developer for their > own personal style with some other neutral style the > content actually distributed. If that day comes, I hope we can all agree to a single format and apply it everywhere as other major projects have done. I think agreeing to a given style is much, much easier for any of us when formatting is fully automatic -- because at that point you don't need to spend mental cycles (and memory!) on it. :-) If I had to guess, I would say the path forward will start with some subsystem maintainers starting to apply clang-format systematically on their trees. That is why I think it is very useful that Dan tries it out and let us know his impressions. Cheers, Miguel _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm