From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7F3FC4CEC9 for ; Wed, 18 Sep 2019 23:40:33 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A20821907 for ; Wed, 18 Sep 2019 23:40:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="g8sIiTEU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A20821907 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 263FD21A02937; Wed, 18 Sep 2019 16:39:44 -0700 (PDT) Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::343; helo=mail-ot1-x343.google.com; envelope-from=dan.j.williams@intel.com; receiver=linux-nvdimm@lists.01.org Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C5E09202EA932 for ; Wed, 18 Sep 2019 16:39:42 -0700 (PDT) Received: by mail-ot1-x343.google.com with SMTP id z6so1481271otb.2 for ; Wed, 18 Sep 2019 16:40:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PDQmKC/gOMi6sqZQA7S/aMJ9nwprCWZMCL6cDdDtiwo=; b=g8sIiTEUBjwC+jypUemhJSEmv702F9Wm/OQ2yvgmSceH+YZ9TxygCePbNrYI9DjIMI QSVrOoN8zmC6+1UX8tJ6WVHh4sA9vGCkaI7q7ebzxUnvEk/XNQxfZ9O9fiZ1mAAArD/F SNacoKkcB2wWT6XFmeZ6gPp7SkarL28rhJGFA8pVIZbbHN1xwRW1q/Y0WFEYWtTXLdD8 xhUMR4yM79Gaiq79K8LkdUGo465NZ6oTNyiAQUBcqjo1C7zHU/fSvIV7MSqKuAHd4p1u Mzm5LHoHcYXkOiVGlntTvZzvSL9EKYpe3ec7uy1T493+iO8CiJlMJTa4zC/87w+4VKaf YQvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PDQmKC/gOMi6sqZQA7S/aMJ9nwprCWZMCL6cDdDtiwo=; b=hoYZN5OXRbC5laEhq+hcRCgrkK5uVuRvazb3Ux4p+lDgL1mf0ilEYtBTPjAngK/fxZ l2mVBHYyG21Yrq2fTyY3JOS3bP+p8NmVm9jKatm43/PwG8HBkr9PrynD3Cyxyqv2vnhv ceW9+NYr1lY5BwzOIoOxvQyVgNC8QgOHHD5YYpvfJ5VZS+O2T0Mg+pN3XeAJyhsgakpQ wukYxn17TsSh5G4uyuob2pFel8cpM0hb+gzpOP60+h0K6QLHKBzJJl2JMrhpmGp+R9Hi J0kUrwQLrFqaSTDJ0SI7m0SxlGWzY5GineesjfDdTXXcxDRehvU0GDMNyLK2dOZh1iNR vDMg== X-Gm-Message-State: APjAAAW3OUS/uOrbr7Rt+6hS+ksul4+aLREkrHTtqxQMYnR4I0HnWHhu S0pgUVfahOeirprYV2A+g0nme7Cg5jRm5EWg6a7tfA== X-Google-Smtp-Source: APXvYqy/eeyRCXrtqIXQiK+EIL6EIZYEXp405qr/gxBJydI6Go09Ucme6OvwkC4jXQNVr3w/eolqtR0naKQMNido3N8= X-Received: by 2002:a9d:5ccc:: with SMTP id r12mr4419959oti.71.1568850030063; Wed, 18 Sep 2019 16:40:30 -0700 (PDT) MIME-Version: 1.0 References: <20190918042148.77553-1-natechancellor@gmail.com> In-Reply-To: <20190918042148.77553-1-natechancellor@gmail.com> From: Dan Williams Date: Wed, 18 Sep 2019 16:40:18 -0700 Message-ID: Subject: Re: [PATCH] libnvdimm/nfit_test: Fix acpi_handle redefinition To: Nathan Chancellor X-BeenThere: linux-nvdimm@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Linux-nvdimm developer list." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-nvdimm , Linux Kernel Mailing List , clang-built-linux , Jason Gunthorpe Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" On Tue, Sep 17, 2019 at 9:23 PM Nathan Chancellor wrote: > > After commit 62974fc389b3 ("libnvdimm: Enable unit test infrastructure > compile checks"), clang warns: > > In file included from > ../drivers/nvdimm/../../tools/testing/nvdimm/test/iomap.c:15: > ../drivers/nvdimm/../../tools/testing/nvdimm/test/nfit_test.h:206:15: > warning: redefinition of typedef 'acpi_handle' is a C11 feature > [-Wtypedef-redefinition] > typedef void *acpi_handle; > ^ > ../include/acpi/actypes.h:424:15: note: previous definition is here > typedef void *acpi_handle; /* Actually a ptr to a NS Node */ > ^ > 1 warning generated. > > The include chain: > > iomap.c -> > linux/acpi.h -> > acpi/acpi.h -> > acpi/actypes.h > nfit_test.h > > Avoid this by including linux/acpi.h in nfit_test.h, which allows us to > remove both the typedef and the forward declaration of acpi_object. > > Link: https://github.com/ClangBuiltLinux/linux/issues/660 > Signed-off-by: Nathan Chancellor > --- > > I know that every maintainer has their own thing with the number of > includes in each header file; this issue can be solved in a various > number of ways, I went with the smallest diff stat. Please solve it in a > different way if you see fit :) > Looks good to me. I'll pick this up for a post v5.4-rc1 push. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm