linux-nvdimm.lists.01.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Ocean He <oceanhehy@gmail.com>
Cc: Ocean HY1 He <hehy1@lenovo.com>,
	linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [ndctl PATCH] ndctl: recover from failed namespace creation
Date: Wed, 28 Nov 2018 14:10:02 -0800	[thread overview]
Message-ID: <CAPcyv4g0aT5VrVQBP-HnZ5Ybg245ao6Y6sS-CPU81AP81G3gcQ@mail.gmail.com> (raw)
In-Reply-To: <1536654669-23828-1-git-send-email-oceanhehy@gmail.com>

On Tue, Sep 11, 2018 at 1:34 AM <oceanhehy@gmail.com> wrote:
>
> From: Ocean He <hehy1@lenovo.com>
>
> When namespace creation failure occurs, the consumed namespace (seed or 0th
> idle) and pfn/dax seed would block next namespace creation. A recovery is
> needed to handle this type failure.
>
> A symptom example (section size is 128MB) based on kernel 4.19-rc2 and
> ndctl v62:
>         # ndctl create-namespace -r region1 -s 100m -t pmem -m fsdax
>         {
>           "dev":"namespace1.0",
>           "mode":"fsdax",
>           "map":"dev",
>           "size":"96.00 MiB (100.66 MB)",
>           "uuid":"ef9a0556-a610-40b5-8c71-43991765a2cc",
>           "raw_uuid":"177b22e2-b7e8-482f-a063-2b8de876d979",
>           "sector_size":512,
>           "blockdev":"pmem1",
>           "numa_node":1
>         }
>         # ndctl create-namespace -r region1 -s 100m -t pmem -m fsdax
>         libndctl: ndctl_pfn_enable: pfn1.1: failed to enable
>           Error: namespace1.1: failed to enable
>         failed to create namespace: No such device or address
>         # ndctl destroy-namespace namespace1.0 -f
>         destroyed 1 namespace
>         # ndctl create-namespace -r region1 -s 128m -t pmem -m fsdax
>         failed to create namespace: Device or resource busy
>
> Signed-off-by: Ocean He <hehy1@lenovo.com>

Apologies, this got lost in my inbox. Looks good, and tests ok as well.

Reviewed-by: Dan Williams <dan.j.williams@intel.com>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

      parent reply	other threads:[~2018-11-28 22:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-11  8:31 [ndctl PATCH] ndctl: recover from failed namespace creation oceanhehy
2018-11-28  8:06 ` [External] " Ocean HY1 He
2018-11-28 22:10 ` Dan Williams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPcyv4g0aT5VrVQBP-HnZ5Ybg245ao6Y6sS-CPU81AP81G3gcQ@mail.gmail.com \
    --to=dan.j.williams@intel.com \
    --cc=hehy1@lenovo.com \
    --cc=linux-nvdimm@lists.01.org \
    --cc=oceanhehy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).