From: Dan Williams <dan.j.williams@intel.com>
To: "Tsaur, Erwin" <erwin.tsaur@intel.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [ndctl PATCH] Expose ndctl_bus_nfit_translate_spa as a public function.
Date: Fri, 26 Feb 2021 11:20:39 -0800 [thread overview]
Message-ID: <CAPcyv4gNddAb0+_q4srSnchGPEda7nD2=0rJR=20_bHUxGeuwg@mail.gmail.com> (raw)
In-Reply-To: <20210224234814.1021-1-erwin.tsaur@intel.com>
On Wed, Feb 24, 2021 at 3:48 PM Tsaur, Erwin <erwin.tsaur@intel.com> wrote:
>
> The motivation is to allow access to ACPI defined NVDIMM Root Device _DSM Function Index 5(Translate SPA). The rest of the _DSM functions, which are mostly ARS related, are already public.
For future reference you'll want to fix your editor to make sure it
wraps at 72 columns for commit messages. If you're a vim user, I have
the following in my .vimrc
set tw=72
...and then you can use the 'gq' command to fixup line wrapping after the fact.
Otherwise, looks good to me. I was worried that you needed to double
check that the bus argument actually is an nfit bus, but
bus_has_translate_spa() already takes care of that, so I think we're
good to go. Longer term if other buses grow the ability to return the
DPA we can add a proper generic wrapper for that, to date I have not
seen much support for RAS brewing in other buses.
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2021-02-26 19:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 23:48 [ndctl PATCH] Expose ndctl_bus_nfit_translate_spa as a public function Tsaur, Erwin
2021-02-26 19:20 ` Dan Williams [this message]
2021-02-26 21:41 ` Verma, Vishal L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4gNddAb0+_q4srSnchGPEda7nD2=0rJR=20_bHUxGeuwg@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=erwin.tsaur@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).