From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-nvdimm-bounces@lists.01.org>
Received: from mail-oi1-x242.google.com (mail-oi1-x242.google.com
 [IPv6:2607:f8b0:4864:20::242])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 844FE212E159A
 for <linux-nvdimm@lists.01.org>; Fri, 26 Jul 2019 16:47:38 -0700 (PDT)
Received: by mail-oi1-x242.google.com with SMTP id u15so41456234oiv.0
 for <linux-nvdimm@lists.01.org>; Fri, 26 Jul 2019 16:45:11 -0700 (PDT)
MIME-Version: 1.0
References: <20190724215741.18556-1-vishal.l.verma@intel.com>
 <20190724215741.18556-12-vishal.l.verma@intel.com>
 <CAPcyv4g82poaqSNZh+Q_QpdWVqjmz3C=BM74Guoe_Wj7bv6kwQ@mail.gmail.com>
 <a6ca723887fab20429929217baa08ae26513eb26.camel@intel.com>
In-Reply-To: <a6ca723887fab20429929217baa08ae26513eb26.camel@intel.com>
From: Dan Williams <dan.j.williams@intel.com>
Date: Fri, 26 Jul 2019 16:44:58 -0700
Message-ID: <CAPcyv4gO=mOkW1b8_MLqs=AuYgopNA1njtaFikvKuNh1-uLb8Q@mail.gmail.com>
Subject: Re: [ndctl PATCH v7 11/13] contrib/ndctl: fix region-id completions
 for daxctl
List-Unsubscribe: <https://lists.01.org/mailman/options/linux-nvdimm>,
 <mailto:linux-nvdimm-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/linux-nvdimm/>
List-Post: <mailto:linux-nvdimm@lists.01.org>
List-Help: <mailto:linux-nvdimm-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/linux-nvdimm>,
 <mailto:linux-nvdimm-request@lists.01.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: linux-nvdimm-bounces@lists.01.org
Sender: "Linux-nvdimm" <linux-nvdimm-bounces@lists.01.org>
To: "Verma, Vishal L" <vishal.l.verma@intel.com>
Cc: "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>, "pasha.tatashin@soleen.com" <pasha.tatashin@soleen.com>, "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
List-ID: <linux-nvdimm@lists.01.org>

On Fri, Jul 26, 2019 at 4:30 PM Verma, Vishal L
<vishal.l.verma@intel.com> wrote:
>
>
> On Thu, 2019-07-25 at 19:55 -0700, Dan Williams wrote:
> > On Wed, Jul 24, 2019 at 2:58 PM Vishal Verma <vishal.l.verma@intel.com
> > > wrote:
> > > The completion helpers for daxctl assumed the region arguments for
> > > specifying daxctl regions were the same as ndctl regions, i.e.
> > > "regionX". This is not true - daxctl region arguments are a simple
> > > numeric 'id'.
> >
> > Oh, that's an unfortunate difference, but too late to change now I
> > think, good find.
> >
> > Reviewed-by: Dan Williams <dan.j.williams@intel.com>
>
> Yep - though I think I like --region=0 better than --region=region0,
> less redundancy.  But agreed, probably too late to change.

We could teach it to allow both. Something for the backlog, but at
least the kernel is using a common number allocator for pmem regions
and hmem regions.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm