linux-nvdimm.lists.01.org archive mirror
 help / color / mirror / Atom feed
* [ndctl PATCH] ndctl/README: Add a missing config setting
@ 2020-03-26  9:25 Dorau, Lukasz
  2020-03-26 17:51 ` Verma, Vishal L
  2020-03-26 18:45 ` Dan Williams
  0 siblings, 2 replies; 4+ messages in thread
From: Dorau, Lukasz @ 2020-03-26  9:25 UTC (permalink / raw)
  To: linux-nvdimm; +Cc: Williams, Dan J, Verma, Vishal L

Add a missing config setting to README.md:
CONFIG_DEV_DAX_PMEM_COMPAT=m

Cc: Williams, Dan J <dan.j.williams@intel.com>
Cc: Verma, Vishal L <vishal.l.verma@intel.com>
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
---
 README.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/README.md b/README.md
index d296c6b..436ada3 100644
--- a/README.md
+++ b/README.md
@@ -65,6 +65,7 @@ loaded.  To build and install nfit_test.ko:
    CONFIG_NVDIMM_PFN=y
    CONFIG_NVDIMM_DAX=y
    CONFIG_DEV_DAX_PMEM=m
+   CONFIG_DEV_DAX_PMEM_COMPAT=m
    ```
 
 1. Build and install the unit test enabled libnvdimm modules in the
-- 
2.25.1
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [ndctl PATCH] ndctl/README: Add a missing config setting
  2020-03-26  9:25 [ndctl PATCH] ndctl/README: Add a missing config setting Dorau, Lukasz
@ 2020-03-26 17:51 ` Verma, Vishal L
  2020-03-26 18:45 ` Dan Williams
  1 sibling, 0 replies; 4+ messages in thread
From: Verma, Vishal L @ 2020-03-26 17:51 UTC (permalink / raw)
  To: linux-nvdimm, Dorau, Lukasz; +Cc: Williams, Dan J

On Thu, 2020-03-26 at 09:25 +0000, Dorau, Lukasz wrote:
> Add a missing config setting to README.md:
> CONFIG_DEV_DAX_PMEM_COMPAT=m
> 
> Cc: Williams, Dan J <dan.j.williams@intel.com>
> Cc: Verma, Vishal L <vishal.l.verma@intel.com>
> Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
> ---
>  README.md | 1 +
>  1 file changed, 1 insertion(+)
> 
Thanks, looks good, I've pushed this out to a 'ld/readme' topic branch,
and it will make its way through pending and master.

	-Vishal
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ndctl PATCH] ndctl/README: Add a missing config setting
  2020-03-26  9:25 [ndctl PATCH] ndctl/README: Add a missing config setting Dorau, Lukasz
  2020-03-26 17:51 ` Verma, Vishal L
@ 2020-03-26 18:45 ` Dan Williams
  2020-03-26 18:47   ` Dan Williams
  1 sibling, 1 reply; 4+ messages in thread
From: Dan Williams @ 2020-03-26 18:45 UTC (permalink / raw)
  To: Dorau, Lukasz; +Cc: linux-nvdimm

On Thu, Mar 26, 2020 at 2:25 AM Dorau, Lukasz <lukasz.dorau@intel.com> wrote:
>
> Add a missing config setting to README.md:
> CONFIG_DEV_DAX_PMEM_COMPAT=m

It's not required anymore as of:

https://github.com/pmem/ndctl/commit/b7991dbc22f31d03a38f3ee2dca4446fb55279e3
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ndctl PATCH] ndctl/README: Add a missing config setting
  2020-03-26 18:45 ` Dan Williams
@ 2020-03-26 18:47   ` Dan Williams
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Williams @ 2020-03-26 18:47 UTC (permalink / raw)
  To: Dorau, Lukasz; +Cc: linux-nvdimm

On Thu, Mar 26, 2020 at 11:45 AM Dan Williams <dan.j.williams@intel.com> wrote:
>
> On Thu, Mar 26, 2020 at 2:25 AM Dorau, Lukasz <lukasz.dorau@intel.com> wrote:
> >
> > Add a missing config setting to README.md:
> > CONFIG_DEV_DAX_PMEM_COMPAT=m
>
> It's not required anymore as of:
>
> https://github.com/pmem/ndctl/commit/b7991dbc22f31d03a38f3ee2dca4446fb55279e3

...and this kernel patch:

https://lore.kernel.org/linux-nvdimm/20200123154720.12097-1-jack@suse.cz/
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-03-26 18:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-26  9:25 [ndctl PATCH] ndctl/README: Add a missing config setting Dorau, Lukasz
2020-03-26 17:51 ` Verma, Vishal L
2020-03-26 18:45 ` Dan Williams
2020-03-26 18:47   ` Dan Williams

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).