From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1C21C3F2D1 for ; Tue, 3 Mar 2020 21:05:20 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D15B20842 for ; Tue, 3 Mar 2020 21:05:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="hxP4lIb3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D15B20842 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id DC7F110FC360A; Tue, 3 Mar 2020 13:06:11 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::341; helo=mail-ot1-x341.google.com; envelope-from=dan.j.williams@intel.com; receiver= Received: from mail-ot1-x341.google.com (mail-ot1-x341.google.com [IPv6:2607:f8b0:4864:20::341]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BDEF51007B191 for ; Tue, 3 Mar 2020 13:06:09 -0800 (PST) Received: by mail-ot1-x341.google.com with SMTP id g96so4489904otb.13 for ; Tue, 03 Mar 2020 13:05:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GzOHtKGs9vZUhp4iJiSpFDnza7AMdo8xQNIINvLoq4c=; b=hxP4lIb3dtmkBovQg4J33LlZEIywlSg2jVUfXOWBxBq3jnVfA8X86T/EvwrGfIQN6J /U0KTguX05L4aeZDQqURd07a+65UXJDiwXo2Hg/WCtZ01L9UdLnT1dw/Y5xkFtSbh3wT KwBr/znV1ED2tk+oTlKcXyLCAfoYeUVaUamLHipAHlZ7+c1K4taxz0B+9wj2YfoJcY0C jVzdVuIzRHq3jBlpSZhQsHhta3ZSwGpiWSBJIcpes57QFdrmy2E1a72QuTfa2LvjEVPI 2cqebxXVHXVE9zoxEc3vdJ+gdWv2Xf8wpW+SMqNOxe4GX651CrTTLR62jFVMk+Hwovzg jRDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GzOHtKGs9vZUhp4iJiSpFDnza7AMdo8xQNIINvLoq4c=; b=eEhooWzeYj9+7U/D5WjVlUNsN8NR5mZ8HrrdRvESqX+Vm5cgxcddwY4fFFNsaE9UNi ToosiJmsfhm7Z6Sr2XKoTHmHsqhhZTQMOtZJG5/5STO3+USgqKCHvtHnRhHV9BP8WJ7x STPulGqIicB/Er6EyxLPp3kUlqdaJl8tH/ZxbY5DqonIPPK6RTy94tq6kj1RmUvdIXEt aa4cHk2+NkHMUqhi7tm4MRYTD8fpihgW15ULO54r0fR9Ozd5J23ckyFNSCQ+HZNmPfGV j1xAKW2mQehGTcgSMO9SEEBSN+GuyA2h8lWPN+pA32M8iEZyNTWKAaHsheD7qkgZYbmc iZ4A== X-Gm-Message-State: ANhLgQ1AKFQHylW+PlKgtYLqzVitHanunm/5gtf+FY8qTHcmILTkFslj 7gq+CqncWInHphk1U2B2FwUWAzm++4t9TGL2zDW7AA== X-Google-Smtp-Source: ADFU+vtCfyS/jHwngdV6cCYqTsmvzxcXe2ZONSCzpDj8RX1/4saFBNdCkAD+FfiZ07o38wO338ZCc0dV5o6mLRiRfTI= X-Received: by 2002:a9d:6c9:: with SMTP id 67mr5029384otx.363.1583269517447; Tue, 03 Mar 2020 13:05:17 -0800 (PST) MIME-Version: 1.0 References: <158300760415.2141307.14060353322051900501.stgit@dwillia2-desk3.amr.corp.intel.com> <158300774836.2141307.13052648687237614794.stgit@dwillia2-desk3.amr.corp.intel.com> <20200303132850.GA21048@quack2.suse.cz> In-Reply-To: <20200303132850.GA21048@quack2.suse.cz> From: Dan Williams Date: Tue, 3 Mar 2020 13:05:06 -0800 Message-ID: Subject: Re: [ndctl PATCH 27/36] ndctl/test: Relax dax_pmem_compat requirement To: Jan Kara Message-ID-Hash: YXKEKKI7Y3VEZDUQH45KJSJZDHMRPWT6 X-Message-ID-Hash: YXKEKKI7Y3VEZDUQH45KJSJZDHMRPWT6 X-MailFrom: dan.j.williams@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: linux-nvdimm X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Mar 3, 2020 at 5:29 AM Jan Kara wrote: > > On Sat 29-02-20 12:22:28, Dan Williams wrote: > > While there are some tests that require the new "dax-bus" device model, > > none of the tests require compatibility mode. Drop the requirement so > > the tests work with DEV_DAX_PMEM_COMPAT=n kernels. > > > > Link: http://lore.kernel.org/r/20200123154720.12097-1-jack@suse.cz > > Cc: Jan Kara > > Signed-off-by: Dan Williams > > The patch looks good to me. Thanks for fixing this! I just have to say that > the strstr(3) usage in this function looks rather unusual to me. Why not > just strcmp(3)? Yeah, this is confusing the 'name' check with the 'path' check, the name check should be fine to use strcmp(). Will fix up. _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org