From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83C99C433E2 for ; Wed, 1 Jul 2020 16:08:32 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EC9020809 for ; Wed, 1 Jul 2020 16:08:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="sgyWg0od" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EC9020809 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 3995111470AAD; Wed, 1 Jul 2020 09:08:32 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::543; helo=mail-ed1-x543.google.com; envelope-from=dan.j.williams@intel.com; receiver= Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A2B0E11460B26 for ; Wed, 1 Jul 2020 09:08:29 -0700 (PDT) Received: by mail-ed1-x543.google.com with SMTP id z17so20467039edr.9 for ; Wed, 01 Jul 2020 09:08:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NgtGRFNzMUt8UwQnpVLH6Q0lK3Q/pmzbcISwUTSvZp4=; b=sgyWg0odMXUUNA+ymUvc43LaYs2s/aJwbFyXWRoPjxwdAxwM/8NDCnpUaFI4p3liR0 gB3SPFv0A/WozVPJacrsy3TT9HIOMMCESTpphsqE92coNdoMTDE/jB5/k99TrA7k0WXT HwfvYQsx393r8hZTsu6RX5RUEhIafmeLpfC5Xxvgan8YQB6lIclWByvvZYmq9DcmZLWN JlL5WK7hHhUXeDny6LC8Ts2exiDWCHCRjEx+DVoYVUZMCGpeUSrXG6yeqYlDTXCkU+hk g1qHbmn4FwKHi5mTo+XYno4GD6wFdoeaM1etI9G0XSOMB6JxPVUPvp1yv+DnjQn7iHAQ vT8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NgtGRFNzMUt8UwQnpVLH6Q0lK3Q/pmzbcISwUTSvZp4=; b=PpliuQ9+9+Gt1gAVG2R88lsB44oIvVLZDuf9rR9E8G5+ns7+RxsSDrlSF66OBE/Ov7 mky22kYqNsCLJsTS0EdAcPMtcHW9rSF8JpaVhSXniqYceRdZKBB17WPKQgV3TPT4A2qu YSbEAydEc0phdBYVI7Zvl6K86kbQhVV1racrGMXrUythbDw/nE0YpeBj7bXGdUFnOUBp BXbzH9GufWMUO744AWMi8e74N3qY120aiF0gDqwTnBrskbMSCiRjUPLGD9BHH4jKatlx kYtnkEbiIKAvVf63VZs382NjeGQ+2vo1iWh730A5mWRKAzcbLnpWBlU2afob5wnIGjrF myWQ== X-Gm-Message-State: AOAM532XuwKeBeJv3xf+p+BsaIBWHxOPt3uW0EWZkwX37moJb6yMmCW5 97EiDGXXBGmGZ+srIa8Gj18I+OW32djn4D+3Cmx/9Q== X-Google-Smtp-Source: ABdhPJwTtEaJeqUJmjVrnga0zb3T87bQXg/qHVHNHjeT7uurwTRSLAeKnsyE6dqNxhAJ1jQ5OrZ9KB+p0GzE9WKAsFg= X-Received: by 2002:a05:6402:21c2:: with SMTP id bi2mr29609575edb.296.1593619707927; Wed, 01 Jul 2020 09:08:27 -0700 (PDT) MIME-Version: 1.0 References: <20200701085947.3354405-1-hch@lst.de> <20200701085947.3354405-17-hch@lst.de> In-Reply-To: <20200701085947.3354405-17-hch@lst.de> From: Dan Williams Date: Wed, 1 Jul 2020 09:08:17 -0700 Message-ID: Subject: Re: [PATCH 16/20] block: move ->make_request_fn to struct block_device_operations To: Christoph Hellwig Message-ID-Hash: HYHVSP6WY2W6Y3GCCLICP3NZDEKCRPPE X-Message-ID-Hash: HYHVSP6WY2W6Y3GCCLICP3NZDEKCRPPE X-MailFrom: dan.j.williams@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Jens Axboe , device-mapper development , Linux Kernel Mailing List , linux-m68k@lists.linux-m68k.org, linux-xtensa@linux-xtensa.org, drbd-dev@lists.linbit.com, linuxppc-dev , linux-bcache@vger.kernel.org, linux-raid , linux-nvdimm , linux-nvme@lists.infradead.org, linux-s390 X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Jul 1, 2020 at 2:01 AM Christoph Hellwig wrote: > > The make_request_fn is a little weird in that it sits directly in > struct request_queue instead of an operation vector. Replace it with > a block_device_operations method called submit_bio (which describes much > better what it does). Also remove the request_queue argument to it, as > the queue can be derived pretty trivially from the bio. > > Signed-off-by: Christoph Hellwig > --- [..] > drivers/nvdimm/blk.c | 5 +- > drivers/nvdimm/btt.c | 5 +- > drivers/nvdimm/pmem.c | 5 +- For drivers/nvdimm Acked-by: Dan Williams _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org