From: Dan Williams <dan.j.williams@intel.com>
To: Vishal Verma <vishal.l.verma@intel.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [ndctl PATCH] ndctl: add util/filter.{c,h} to ndctl_SOURCES in Makefile.am
Date: Fri, 31 Jan 2020 15:33:00 -0800 [thread overview]
Message-ID: <CAPcyv4iP0oe=UJweX=GTBD0a7VO=pfNNdsLzDkhQeOcihFHzPQ@mail.gmail.com> (raw)
In-Reply-To: <20200131224756.29821-1-vishal.l.verma@intel.com>
On Fri, Jan 31, 2020 at 2:48 PM Vishal Verma <vishal.l.verma@intel.com> wrote:
>
> ndctl/Makefile.am neglected to explicitly add util/filter.{c,h} to
> ndctl_SOURCES. In the past, this has been a cause for distro build
> failures.
>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> ---
> ndctl/Makefile.am | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/ndctl/Makefile.am b/ndctl/Makefile.am
> index 264c4ed..49c6c4a 100644
> --- a/ndctl/Makefile.am
> +++ b/ndctl/Makefile.am
> @@ -18,7 +18,9 @@ ndctl_SOURCES = ndctl.c \
> check.c \
> region.c \
> dimm.c \
> - ../util/log.c \
> + ../util/log.c \
> + ../util/filter.c \
> + ../util/filter.h \
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Not sure why 'make distcheck' did not hit this previously.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
prev parent reply other threads:[~2020-01-31 23:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 22:47 [ndctl PATCH] ndctl: add util/filter.{c,h} to ndctl_SOURCES in Makefile.am Vishal Verma
2020-01-31 23:33 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4iP0oe=UJweX=GTBD0a7VO=pfNNdsLzDkhQeOcihFHzPQ@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).