linux-nvdimm.lists.01.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] libnvdimm/region: Update is_nvdimm_sync check to handle volatile regions
Date: Tue, 24 Sep 2019 10:12:17 -0700	[thread overview]
Message-ID: <CAPcyv4ij2+i9O15ZTx3VSLEF7wQM5ukfncVY42g4S1VWX8zTrA@mail.gmail.com> (raw)
In-Reply-To: <CAPcyv4iQbM5R0dukZX8wCQx4dD8NAevQWnHWe4hC7kHBcDcNow@mail.gmail.com>

On Tue, Sep 24, 2019 at 9:57 AM Dan Williams <dan.j.williams@intel.com> wrote:
>
> On Tue, Sep 24, 2019 at 4:43 AM Aneesh Kumar K.V
> <aneesh.kumar@linux.ibm.com> wrote:
> >
> > We should consider volatile regions synchronous so that we are resilient to
> > OS crashes. This is needed when we have hypervisor like KVM exporting a ramdisk
> > as pmem dimms.
>
> We have a hard time understanding what agent is being referenced when
> we use "we" in a patch changelog. We would prefer that we consider not
> using "we" in favor of explicitly named agents, or otherwise review
> the changelog to make sure that "we" is clearly discernable. We will
> fix it up this time when applying, but we hope we have made it clear
> how confusing liberal use of "we" can be.

To be clear, I'm not strictly opposed to using "we" when it is
established which we is being referred and stays constant throughout
the description. This instance caught my eye again because the first
couple "we"s seems to be the kernel, and the last we seems to be a
user platform configuration.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  reply	other threads:[~2019-09-24 17:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-24 11:43 [PATCH] libnvdimm/region: Update is_nvdimm_sync check to handle volatile regions Aneesh Kumar K.V
2019-09-24 11:52 ` Pankaj Gupta
2019-09-24 16:57 ` Dan Williams
2019-09-24 17:12   ` Dan Williams [this message]
2019-09-25  3:54     ` Aneesh Kumar K.V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPcyv4ij2+i9O15ZTx3VSLEF7wQM5ukfncVY42g4S1VWX8zTrA@mail.gmail.com \
    --to=dan.j.williams@intel.com \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).