From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB183C3F2D1 for ; Wed, 4 Mar 2020 20:57:09 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F5A820842 for ; Wed, 4 Mar 2020 20:57:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="Jrd8sZi8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F5A820842 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id C749D10FC36ED; Wed, 4 Mar 2020 12:58:00 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::241; helo=mail-oi1-x241.google.com; envelope-from=dan.j.williams@intel.com; receiver= Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A0DEA10FC36EA for ; Wed, 4 Mar 2020 12:57:58 -0800 (PST) Received: by mail-oi1-x241.google.com with SMTP id r16so3581520oie.6 for ; Wed, 04 Mar 2020 12:57:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NeXW7YNWKtPM2qhkPxW/kiKtKjk7UpmXN4m91WTJNCM=; b=Jrd8sZi8FK4jANBFdzU+UpRWAbAAy7EQjaFH7cCT7k1bLXlDXEqYwWTvoy3XqwXx9N oje8H4L7MQFhh/bZTgymvv2Pm37WnJid2buYJA06o01S3aAmAE8SEIX9iecggKE4D5CE 61KhXhqzn6oIfP2TyxecT/+zPVW/hkGof5elxwtp5/Z+NXZpjf7XRFXWQl6Mu6GIZoOt 3f4+ZqUK0FE9Egdunl86lWrAB4VPqJuYmuCSW0UKbBKN4yNFCOOzR4iO+QBmSS1MIDz0 6PS4VpG3X07nTssv+skbDbHfMb1PQmdi4QqJ5NUXJoDp2a2BbU134cApL9tz3ODL8TiU FUMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NeXW7YNWKtPM2qhkPxW/kiKtKjk7UpmXN4m91WTJNCM=; b=b5B1vTK8m7hKgn50G0FyvW3GtS48rTiGflYD++318ClAsKQBdOw74/vSYiw4Gfr3Ew oRG/rFWut9G+ejaD6Vb8MYZnfrz8JZ3LCoKVrHBgDN1WPSWQU7Y2+ohr4JuT95+n2jQg mbAgSWcadZ6dEeaJKB6aZA6aRSpnPy/hbTgCPxL9IPM+rdFFHr5MMqVs33gVUpKJjmqO aCxB6xyuTfZSln/3QD6VTtUbACB/TMHuAon1GGhbimmW6h9t/oHXMrJdjkx3uIx8mOwj ZhZVKYONoehqMOyLtNNToBoh0I6PkZV9RAZTyCCo3Rx+cJCUH5ZXUKNmoW+vRxntdoYN SlHA== X-Gm-Message-State: ANhLgQ3wpc1bUKB3kHoNwJoeeLjLAmZyXTjvHuuwyzEdQHfNtnMzdqmD SkStjv+wHF4Zdac5+XZoYl3U9Kr165C3A430vE36IA== X-Google-Smtp-Source: ADFU+vtFbEv31ANDFs0/4N9Z/l6H9sqYzjPTVswiZTAKAsgysts9zHxyIRsH1as4Wq2QvfA+x1ko0P0794u+WWSSnqw= X-Received: by 2002:aca:ed58:: with SMTP id l85mr1490175oih.70.1583355426008; Wed, 04 Mar 2020 12:57:06 -0800 (PST) MIME-Version: 1.0 References: <20200223165724.23816-1-mcroce@redhat.com> In-Reply-To: <20200223165724.23816-1-mcroce@redhat.com> From: Dan Williams Date: Wed, 4 Mar 2020 12:56:54 -0800 Message-ID: Subject: Re: [PATCH] block: refactor duplicated macros To: Matteo Croce Message-ID-Hash: D3W55KRJEFTGPODF5P5COO5QXKNW4QC2 X-Message-ID-Hash: D3W55KRJEFTGPODF5P5COO5QXKNW4QC2 X-MailFrom: dan.j.williams@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: linux-block@vger.kernel.org, Linux Kernel Mailing List , linux-nvdimm , linux-bcache@vger.kernel.org, linux-raid , linux-mmc@vger.kernel.org, xen-devel , linux-scsi , linux-nfs@vger.kernel.org, Jens Axboe , "James E.J. Bottomley" , Ulf Hansson , Anna Schumaker X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sun, Feb 23, 2020 at 9:04 AM Matteo Croce wrote: > > The macros PAGE_SECTORS, PAGE_SECTORS_SHIFT and SECTOR_MASK are defined > several times in different flavours across the whole tree. > Define them just once in a common header. > > Signed-off-by: Matteo Croce > --- > block/blk-lib.c | 2 +- > drivers/block/brd.c | 3 --- > drivers/block/null_blk_main.c | 4 ---- > drivers/block/zram/zram_drv.c | 8 ++++---- > drivers/block/zram/zram_drv.h | 2 -- > drivers/dax/super.c | 2 +- For the dax change: Acked-by: Dan Williams However... [..] > include/linux/blkdev.h | 4 ++++ [..] > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 053ea4b51988..b3c9be6906a0 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -910,6 +910,10 @@ static inline struct request_queue *bdev_get_queue(struct block_device *bdev) > #define SECTOR_SIZE (1 << SECTOR_SHIFT) > #endif > > +#define PAGE_SECTORS_SHIFT (PAGE_SHIFT - SECTOR_SHIFT) > +#define PAGE_SECTORS (1 << PAGE_SECTORS_SHIFT) > +#define SECTOR_MASK (PAGE_SECTORS - 1) > + ...I think SECTOR_MASK is misnamed given it considers pages, and should probably match the polarity of PAGE_MASK, i.e. #define PAGE_SECTORS_MASK (~(PAGE_SECTORS - 1)) _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org