Linux-NVDIMM Archive on
 help / color / Atom feed
From: Dan Williams <>
To: "Li, Redhairer" <>
Cc: "" <>
Subject: Re: daxctl: Change region input type from INTEGER to STRING.
Date: Tue, 3 Dec 2019 17:50:24 -0800
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Dec 2, 2019 at 6:43 PM Li, Redhairer <> wrote:
> I have squashed my previous two change.
> Please refer it.

The logic looks good, and it's passing my manual tests. However the
unit tests are currently failing, so I got sidetracked trying to look
into that. Not your issue, but it prevented me from responding right

As for the final version of the patch:

The changelog grammar needs a small fixup. How about:

Allow daxctl to accept both <region-id>, and region name as region
parameter. For example:

    daxctl list -r region5
    daxctl list -r 5

There were some whitespace errors in util_daxctl_region_filter()
(indentation for a continued if statement and missing space around
"=="). You can use vim's default C identing.

It also needs to be resent as a plain text patch, not an attachment,
otherwise patchwork won't pick it up [1]. For this first submission
you can send it again as an attachment and I'll resend to the list.

Linux-nvdimm mailing list --
To unsubscribe send an email to

      reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-21  9:18 Li, Redhairer
2019-11-26 19:21 ` Dan Williams
2019-11-28  6:56   ` Li, Redhairer
2019-12-03  2:38     ` Li, Redhairer
2019-12-04  1:50       ` Dan Williams [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NVDIMM Archive on

Archives are clonable:
	git clone --mirror linux-nvdimm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvdimm linux-nvdimm/ \
	public-inbox-index linux-nvdimm

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone