linux-nvdimm.lists.01.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: "Li, Redhairer" <redhairer.li@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] daxctl: Change region input type from INTEGER to STRING.
Date: Sun, 29 Dec 2019 22:02:47 -0800	[thread overview]
Message-ID: <CAPcyv4jEEKjpc8_Y0EBFH=4uHcTGGVpnSEOt425ARdTY3nuMqQ@mail.gmail.com> (raw)
In-Reply-To: <SN6PR11MB32643D4FCE4E828182CB78AF92240@SN6PR11MB3264.namprd11.prod.outlook.com>

On Sat, Dec 28, 2019 at 11:54 PM Li, Redhairer <redhairer.li@intel.com> wrote:
>
> OK, got it.
> I have figured out the problem.
> I pass wrong parameter to util_daxctl_region_filter.
>
> But I found two other problems before I apply my patch.
>
> 1. DAX device already online after reconfigure it to system-ram.
>
> "$DAXCTL" reconfigure-device -N -m system-ram "$daxdev"
>
> If daxctl-device.sh do online-memory again,
> it makes FAIL daxctl-devices.sh (exit status: 1) even I add --no-online when reconfigure-device
>
> + ../daxctl/daxctl reconfigure-device -N -m system-ram --no-online dax0.0
> libdaxctl: memblock_in_dev: dax0.0: memory0: Unable to determine phys_index: Success
> reconfigured 1 device
> [
>   {
>     "chardev":"dax0.0",
>     "size":262144000,
>     "target_node":0,
>     "mode":"system-ram",
>     "movable":false
>   }
> ]
> ++ daxctl_get_mode dax0.0
> ++ ../daxctl/daxctl list -d dax0.0
> ++ jq -er '.[].mode'
> libdaxctl: memblock_in_dev: dax0.0: memory0: Unable to determine phys_index: Success
> + [[ system-ram == \s\y\s\t\e\m\-\r\a\m ]]
> + ../daxctl/daxctl online-memory dax0.0
> libdaxctl: memblock_in_dev: dax0.0: memory0: Unable to determine phys_index: Success
> libdaxctl: memblock_in_dev: dax0.0: memory0: Unable to determine phys_index: Success
> dax0.0:
>   WARNING: detected a race while onlining memory
>   Some memory may not be in the expected zone. It is
>   recommended to disable any other onlining mechanisms,
>   and retry. If onlining is to be left to other agents,
>   use the --no-online option to suppress this warning

This is likely because Ubuntu ships a udev rule that automatically
onlines hot-added memory. We've talked about a way to auto-detect when
a distribution ships a udev configuration like this, but for now this
warning message is the best we can do.

[..]>
> 2.  2 nvdimm will make daxctl-devices.sh FAIL

Do you mean a system with real nvdimms makes daxctl-devices.sh fail?
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

  reply	other threads:[~2019-12-30  6:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04  2:33 [PATCH] daxctl: Change region input type from INTEGER to STRING Li, Redhairer
2019-12-04  2:42 ` Dan Williams
2019-12-25 10:33   ` Li, Redhairer
2019-12-25 21:18     ` Dan Williams
2019-12-26  1:48       ` Li, Redhairer
2019-12-26  2:22         ` Li, Redhairer
2019-12-26  4:01           ` Li, Redhairer
2019-12-26 17:54             ` Dan Williams
2019-12-29  7:54               ` Li, Redhairer
2019-12-30  6:02                 ` Dan Williams [this message]
2020-01-01 13:36                   ` Li, Redhairer
2019-12-26 17:48           ` Dan Williams
2019-12-28  3:08             ` Li, Redhairer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPcyv4jEEKjpc8_Y0EBFH=4uHcTGGVpnSEOt425ARdTY3nuMqQ@mail.gmail.com' \
    --to=dan.j.williams@intel.com \
    --cc=linux-nvdimm@lists.01.org \
    --cc=redhairer.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).