From: Dan Williams <dan.j.williams@intel.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Jan Kara <jack@suse.cz>, linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] tools/testing/nvdimm: Fix compilation failure without CONFIG_DEV_DAX_PMEM_COMPAT
Date: Wed, 12 Feb 2020 12:49:41 -0800 [thread overview]
Message-ID: <CAPcyv4jKKfWCNHtxQDYcKV_6hMXWrATkppQ4v=4E0teOmT8+mg@mail.gmail.com> (raw)
In-Reply-To: <x498sl73nsc.fsf@segfault.boston.devel.redhat.com>
On Wed, Feb 12, 2020 at 6:04 AM Jeff Moyer <jmoyer@redhat.com> wrote:
>
> Jan Kara <jack@suse.cz> writes:
>
> > When a kernel is configured without CONFIG_DEV_DAX_PMEM_COMPAT, the
> > compilation of tools/testing/nvdimm fails with:
> >
> > Building modules, stage 2.
> > MODPOST 11 modules
> > ERROR: "dax_pmem_compat_test" [tools/testing/nvdimm/test/nfit_test.ko] undefined!
> >
> > Fix the problem by calling dax_pmem_compat_test() only if the kernel has
> > the required functionality.
> >
> > Signed-off-by: Jan Kara <jack@suse.cz>
>
> What's the motivation? Is this just to fix randconfig builds? The
> reason I ask is that the test suite will expect to be able to find the
> dax_pmem_compat module, so it doesn't make sense to me to disable those
> tests only in the kernel as you'll hit a problem when running the tests
> anyway.
Yeah, at a minimum you'd also need to go fix up nfit_test_init() to
not check for the dax_pmem_compat module:
https://github.com/pmem/ndctl/blob/master/test/core.c#L119
> But, I understand if you want to prevent build bots from hitting
> compilation failures due to this.
Hmm, build bots would only hit what's covered by
CONFIG_NVDIMM_TEST_BUILD, and that's only building
tools/testing/nvdimm/test/iomap.c.
Jan, were you just looking to use nfit_test outside of running the
ndctl test suites? Or was this just a drive-by compilation test?
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2020-02-12 20:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 15:47 [PATCH] tools/testing/nvdimm: Fix compilation failure without CONFIG_DEV_DAX_PMEM_COMPAT Jan Kara
2020-02-10 11:28 ` Jan Kara
2020-02-12 14:04 ` Jeff Moyer
2020-02-12 20:49 ` Dan Williams [this message]
2020-02-13 20:58 ` Jan Kara
2020-02-14 16:13 ` Dan Williams
2020-02-17 8:16 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4jKKfWCNHtxQDYcKV_6hMXWrATkppQ4v=4E0teOmT8+mg@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).