From: Dan Williams <dan.j.williams@intel.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] nvdimm/of_pmem: Provide a unique name for bus provider
Date: Fri, 30 Aug 2019 07:40:02 -0700 [thread overview]
Message-ID: <CAPcyv4jaz2ZOGSSWov9gHn2FgBpX=RzeQy7_ZpL35tt3MQAANA@mail.gmail.com> (raw)
In-Reply-To: <ccf23b5e-4dc8-14c6-31db-cef3bfdf7269@linux.ibm.com>
On Thu, Aug 29, 2019 at 9:45 PM Aneesh Kumar K.V
<aneesh.kumar@linux.ibm.com> wrote:
>
> On 8/30/19 10:10 AM, Dan Williams wrote:
> > On Thu, Aug 29, 2019 at 9:31 PM Aneesh Kumar K.V
> > <aneesh.kumar@linux.ibm.com> wrote:
> >>
> >> patchwork-bot+linux-nvdimm@kernel.org writes:
> >>
> >>> Hello:
> >>>
> >>> This patch was applied to nvdimm/nvdimm.git (refs/heads/libnvdimm-for-next).
> >>>
> >>> On Wed, 7 Aug 2019 09:30:29 +0530 you wrote:
> >>>> ndctl utility requires the ndbus to have unique names. If not while
> >>>> enumerating the bus in userspace it drops bus with similar names.
> >>>> This results in us not listing devices beneath the bus.
> >>>>
> >>>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> >>>> ---
> >>>> drivers/nvdimm/of_pmem.c | 2 +-
> >>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>>
> >>> Here is a summary with links:
> >>> - nvdimm/of_pmem: Provide a unique name for bus provider
> >>> https://git.kernel.org/nvdimm/nvdimm/c/49bddc73d15c25a68e4294d76fc74519fda984cd
> >>>
> >>> You are awesome, thank you!
> >>
> >> We decided to fix this in ndctl tool? If we go with ndctl fix, we
> >> can drop the kernel change.
> >
> > Oh, I was planning to do both any concerns if I keep the kernel
> > change, otherwise I'll need to rebase the branch.
> >
>
> I guess rebasing is not going to be nice. So we can keep the patch and
> if we are really need to move the provider name to indicate backend
> driver, I will fixup both of_pmem and papr_scm together.
Another reason to make the kernel change is to improve compatibility
with older ndctl releases.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2019-08-30 14:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 4:00 [PATCH] nvdimm/of_pmem: Provide a unique name for bus provider Aneesh Kumar K.V
2019-08-07 4:13 ` Dan Williams
2019-08-07 4:17 ` Aneesh Kumar K.V
2019-08-07 4:52 ` Dan Williams
2019-08-07 6:00 ` Aneesh Kumar K.V
2019-08-07 15:34 ` Dan Williams
2019-08-07 5:42 ` Vaibhav Jain
[not found] ` <156711523501.12658.8795324273505326478.git-patchwork-notify@kernel.org>
2019-08-30 4:31 ` Aneesh Kumar K.V
2019-08-30 4:40 ` Dan Williams
2019-08-30 4:45 ` Aneesh Kumar K.V
2019-08-30 14:40 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4jaz2ZOGSSWov9gHn2FgBpX=RzeQy7_ZpL35tt3MQAANA@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).