From: Dan Williams <dan.j.williams@intel.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH v4 2/2] libnvdimm/namespace: Differentiate between probe mapping and runtime mapping
Date: Thu, 31 Oct 2019 11:52:23 -0700 [thread overview]
Message-ID: <CAPcyv4jv+zx7PSLGuxaa1OMQmmEnws2VgUN43YqqEvoh1yFowA@mail.gmail.com> (raw)
In-Reply-To: <20191031105741.102793-2-aneesh.kumar@linux.ibm.com>
On Thu, Oct 31, 2019 at 3:58 AM Aneesh Kumar K.V
<aneesh.kumar@linux.ibm.com> wrote:
>
> The nvdimm core currently maps the full namespace to an ioremap range
> while probing the namespace mode. This can result in probe failures on
> architectures that have limited ioremap space.
>
> For example, with a large btt namespace that consumes most of I/O remap
> range, depending on the sequence of namespace initialization, the user
> can find a pfn namespace initialization failure due to unavailable I/O
> remap space which nvdimm core uses for temporary mapping.
>
> nvdimm core can avoid this failure by only mapping the reserved info
> block area to check for pfn superblock type and map the full namespace
> resource only before using the namespace.
>
> Given that personalities like BTT can be layered on top of any namespace
> type create a generic form of devm_nsio_enable (devm_namespace_enable)
> and use it inside the per-personality attach routines. Now
> devm_namespace_enable() is always paired with disable unless the mapping
> is going to be used for long term runtime access.
Looks good to me, applied.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2019-10-31 18:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 10:57 [PATCH v4 1/2] libnvdimm/pfn_dev: Don't clear device memmap area during generic namespace probe Aneesh Kumar K.V
2019-10-31 10:57 ` [PATCH v4 2/2] libnvdimm/namespace: Differentiate between probe mapping and runtime mapping Aneesh Kumar K.V
2019-10-31 18:52 ` Dan Williams [this message]
2019-10-31 18:50 ` [PATCH v4 1/2] libnvdimm/pfn_dev: Don't clear device memmap area during generic namespace probe Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4jv+zx7PSLGuxaa1OMQmmEnws2VgUN43YqqEvoh1yFowA@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).