From: "ruansy.fnst@fujitsu.com" <ruansy.fnst@fujitsu.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"darrick.wong@oracle.com" <darrick.wong@oracle.com>,
"willy@infradead.org" <willy@infradead.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"david@fromorbit.com" <david@fromorbit.com>,
"hch@lst.de" <hch@lst.de>, "rgoldwyn@suse.de" <rgoldwyn@suse.de>
Subject: RE: [PATCH v5 0/7] fsdax,xfs: Add reflink&dedupe support for fsdax
Date: Tue, 11 May 2021 05:53:51 +0000 [thread overview]
Message-ID: <OSBPR01MB2920C085D788A9F918107F33F4539@OSBPR01MB2920.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20210511035706.GL8582@magnolia>
> -----Original Message-----
> From: Darrick J. Wong <djwong@kernel.org>
> Sent: Tuesday, May 11, 2021 11:57 AM
> Subject: Re: [PATCH v5 0/7] fsdax,xfs: Add reflink&dedupe support for fsdax
>
> On Tue, May 11, 2021 at 11:09:26AM +0800, Shiyang Ruan wrote:
> > This patchset is attempt to add CoW support for fsdax, and take XFS,
> > which has both reflink and fsdax feature, as an example.
>
> Slightly off topic, but I noticed all my pmem disappeared once I rolled forward to
> 5.13-rc1. Am I the only lucky one? Qemu 4.2, with fake memory devices
> backed by tmpfs files -- info qtree says they're there, but the kernel doesn't show
> anything in /proc/iomem.
I have the same situation on 5.13-rc1 too. (Qemu 5.2.0, fake memory device backed by files)
I tested this code in v5.12-rc8 and then rebased it to v5.13-rc1... It's my bad for not testing again.
--
Thanks,
Ruan Shiyang.
>
> --D
>
> > Changes from V4:
> > - Fix the mistake of breaking dax layout for two inodes
> > - Add CONFIG_FS_DAX judgement for fsdax code in remap_range.c
> > - Fix other small problems and mistakes
> >
> > Changes from V3:
> > - Take out the first 3 patches as a cleanup patchset[1], which has been
> > sent yesterday.
> > - Fix usage of code in dax_iomap_cow_copy()
> > - Add comments for macro definitions
> > - Fix other code style problems and mistakes
> >
> > One of the key mechanism need to be implemented in fsdax is CoW. Copy
> > the data from srcmap before we actually write data to the destance
> > iomap. And we just copy range in which data won't be changed.
> >
> > Another mechanism is range comparison. In page cache case, readpage()
> > is used to load data on disk to page cache in order to be able to
> > compare data. In fsdax case, readpage() does not work. So, we need
> > another compare data with direct access support.
> >
> > With the two mechanisms implemented in fsdax, we are able to make
> > reflink and fsdax work together in XFS.
> >
> > Some of the patches are picked up from Goldwyn's patchset. I made
> > some changes to adapt to this patchset.
> >
> >
> > (Rebased on v5.13-rc1 and patchset[1])
> > [1]: https://lkml.org/lkml/2021/4/22/575
> >
> > Shiyang Ruan (7):
> > fsdax: Introduce dax_iomap_cow_copy()
> > fsdax: Replace mmap entry in case of CoW
> > fsdax: Add dax_iomap_cow_copy() for dax_iomap_zero
> > iomap: Introduce iomap_apply2() for operations on two files
> > fsdax: Dedup file range to use a compare function
> > fs/xfs: Handle CoW for fsdax write() path
> > fs/xfs: Add dax dedupe support
> >
> > fs/dax.c | 206
> +++++++++++++++++++++++++++++++++++------
> > fs/iomap/apply.c | 52 +++++++++++
> > fs/iomap/buffered-io.c | 2 +-
> > fs/remap_range.c | 57 ++++++++++--
> > fs/xfs/xfs_bmap_util.c | 3 +-
> > fs/xfs/xfs_file.c | 11 +--
> > fs/xfs/xfs_inode.c | 66 ++++++++++++-
> > fs/xfs/xfs_inode.h | 1 +
> > fs/xfs/xfs_iomap.c | 61 +++++++++++-
> > fs/xfs/xfs_iomap.h | 4 +
> > fs/xfs/xfs_iops.c | 7 +-
> > fs/xfs/xfs_reflink.c | 15 +--
> > include/linux/dax.h | 7 +-
> > include/linux/fs.h | 12 ++-
> > include/linux/iomap.h | 7 +-
> > 15 files changed, 449 insertions(+), 62 deletions(-)
> >
> > --
> > 2.31.1
> >
> >
> >
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
prev parent reply other threads:[~2021-05-11 5:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 3:09 [PATCH v5 0/7] fsdax,xfs: Add reflink&dedupe support for fsdax Shiyang Ruan
2021-05-11 3:09 ` [PATCH v5 1/7] fsdax: Introduce dax_iomap_cow_copy() Shiyang Ruan
2021-05-12 1:08 ` Darrick J. Wong
2021-05-13 7:57 ` ruansy.fnst
2021-05-13 15:02 ` Darrick J. Wong
2021-05-11 3:09 ` [PATCH v5 2/7] fsdax: Replace mmap entry in case of CoW Shiyang Ruan
2021-05-12 1:09 ` Darrick J. Wong
2021-05-11 3:09 ` [PATCH v5 3/7] fsdax: Add dax_iomap_cow_copy() for dax_iomap_zero Shiyang Ruan
2021-05-12 1:17 ` Darrick J. Wong
2021-05-12 1:37 ` ruansy.fnst
2021-05-12 2:27 ` Mika Penttilä
2021-05-13 7:48 ` ruansy.fnst
2021-05-11 3:09 ` [PATCH v5 4/7] iomap: Introduce iomap_apply2() for operations on two files Shiyang Ruan
2021-05-11 3:09 ` [PATCH v5 5/7] fsdax: Dedup file range to use a compare function Shiyang Ruan
2021-05-12 1:23 ` Darrick J. Wong
2021-05-14 8:35 ` ruansy.fnst
2021-05-14 16:03 ` Darrick J. Wong
2021-05-11 3:09 ` [PATCH v5 6/7] fs/xfs: Handle CoW for fsdax write() path Shiyang Ruan
2021-05-12 1:30 ` Darrick J. Wong
2021-05-11 3:09 ` [PATCH v5 7/7] fs/xfs: Add dax dedupe support Shiyang Ruan
2021-05-12 1:04 ` Darrick J. Wong
2021-05-12 1:26 ` ruansy.fnst
2021-05-11 3:57 ` [PATCH v5 0/7] fsdax,xfs: Add reflink&dedupe support for fsdax Darrick J. Wong
2021-05-11 5:53 ` ruansy.fnst [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSBPR01MB2920C085D788A9F918107F33F4539@OSBPR01MB2920.jpnprd01.prod.outlook.com \
--to=ruansy.fnst@fujitsu.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=rgoldwyn@suse.de \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).