From: Coly Li <colyli@suse.de>
To: "Verma, Vishal L" <vishal.l.verma@intel.com>
Cc: "pankaj.gupta.linux@gmail.com" <pankaj.gupta.linux@gmail.com>,
"snitzer@redhat.com" <snitzer@redhat.com>,
"jack@suse.com" <jack@suse.com>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: flood of "dm-X: error: dax access failed" due to 5.9 commit 231609785cbfb
Date: Thu, 3 Sep 2020 11:32:42 +0800 [thread overview]
Message-ID: <a091cc35-893a-fc10-6b4f-231c399b9629@suse.de> (raw)
In-Reply-To: <8dc419e607ffa0e2baa6bd5795b4956fb945ebad.camel@intel.com>
On 2020/9/3 07:05, Verma, Vishal L wrote:
> On Thu, 2020-09-03 at 00:40 +0800, Coly Li wrote:
>> On 2020/9/3 00:04, Mike Snitzer wrote:
>>> 5.9 commit 231609785cbfb ("dax: print error message by pr_info() in
>>> __generic_fsdax_supported()") switched from pr_debug() to pr_info().
>>>
>>> The justification in the commit header is really inadequate. If there
>>> is a problem that you need to drill in on, repeat the testing after
>>> enabling the dynamic debugging.
>>>
>>> Otherwise, now all DM devices that aren't layered on DAX capable devices
>>> spew really confusing noise to users when they simply activate their
>>> non-DAX DM devices:
>>>
>>> [66567.129798] dm-6: error: dax access failed (-5)
>>> [66567.134400] dm-6: error: dax access failed (-5)
>>> [66567.139152] dm-6: error: dax access failed (-5)
>>> [66567.314546] dm-2: error: dax access failed (-95)
>>> [66567.319380] dm-2: error: dax access failed (-95)
>>> [66567.324254] dm-2: error: dax access failed (-95)
>>> [66567.479025] dm-2: error: dax access failed (-95)
>>> [66567.483713] dm-2: error: dax access failed (-95)
>>> [66567.488722] dm-2: error: dax access failed (-95)
>>> [66567.494061] dm-2: error: dax access failed (-95)
>>> [66567.498823] dm-2: error: dax access failed (-95)
>>> [66567.503693] dm-2: error: dax access failed (-95)
>>>
>>> commit 231609785cbfb must be reverted.
>>>
>>> Please advise, thanks.
>>
>> Adrian Huang from Lenovo posted a patch, which titled: dax: do not print
>> error message for non-persistent memory block device
>>
>> It fixes the issue, but no response for now. Maybe we should take this fix.
>>
>
> Mike, Coly,
>
> I applied Adrians patch, and submitted it - it is already in v5.9-rc3 -
> c2affe920b0e dax: do not print error message for non-persistent memory block device
>
Hi Verma,
Thank you for taking it into mainline :-)
Coly Li
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
prev parent reply other threads:[~2020-09-03 3:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 16:04 flood of "dm-X: error: dax access failed" due to 5.9 commit 231609785cbfb Mike Snitzer
2020-09-02 16:40 ` Coly Li
2020-09-02 16:44 ` Mike Snitzer
2020-09-02 16:46 ` Coly Li
2020-09-02 16:51 ` Mike Snitzer
2020-09-02 16:53 ` Coly Li
2020-09-03 5:05 ` Coly Li
2020-09-03 5:20 ` Coly Li
2020-09-03 8:37 ` Coly Li
2020-09-03 11:24 ` [External] " Adrian Huang12
2020-09-03 11:31 ` Coly Li
2020-09-03 11:09 ` Adrian Huang12
2020-09-03 11:24 ` Coly Li
2020-09-02 23:05 ` Verma, Vishal L
2020-09-03 3:32 ` Coly Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a091cc35-893a-fc10-6b4f-231c399b9629@suse.de \
--to=colyli@suse.de \
--cc=dm-devel@redhat.com \
--cc=jack@suse.com \
--cc=linux-nvdimm@lists.01.org \
--cc=pankaj.gupta.linux@gmail.com \
--cc=snitzer@redhat.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).