From: Oscar Salvador <osalvador@suse.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>,
akpm@linux-foundation.org,
"Naoya Horiguchi" <nao.horiguchi@gmail.com>,
"Michal Hocko" <mhocko@kernel.org>,
"David Hildenbrand" <david@redhat.com>,
stable@vger.kernel.org, linux-mm@kvack.org,
linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/5] mm: Fix page reference leak in soft_offline_page()
Date: Thu, 14 Jan 2021 07:30:11 +0100 [thread overview]
Message-ID: <c470b3d344e560e5c1c7b57f9bf83a37@suse.de> (raw)
In-Reply-To: <CAPcyv4gVPMUD7P0KwAY9xk3xBkodPExeJVG6i9=9FGexbJZpBw@mail.gmail.com>
On 2021-01-14 07:18, Dan Williams wrote:
> To be honest I dislike the entire flags based scheme for communicating
> the fact that page reference obtained by madvise needs to be dropped
> later. I'd rather pass a non-NULL 'struct page *' than redo
> pfn_to_page() conversions in the leaf functions, but that's a much
> larger change.
We tried to remove that flag in the past but for different reasons.
I will have another look to see what can be done.
Thanks
--
Oscar Salvador
SUSE L3
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2021-01-14 6:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 0:43 [PATCH v4 0/5] mm: Fix pfn_to_online_page() with respect to ZONE_DEVICE Dan Williams
2021-01-14 0:43 ` [PATCH v4 1/5] mm: Move pfn_to_online_page() out of line Dan Williams
2021-01-20 10:11 ` Michal Hocko
2021-01-14 0:43 ` [PATCH v4 2/5] mm: Teach pfn_to_online_page() to consider subsection validity Dan Williams
2021-01-20 10:24 ` Michal Hocko
2021-01-14 0:43 ` [PATCH v4 3/5] mm: Teach pfn_to_online_page() about ZONE_DEVICE section collisions Dan Williams
2021-01-20 10:30 ` Michal Hocko
2021-01-14 0:43 ` [PATCH v4 4/5] mm: Fix page reference leak in soft_offline_page() Dan Williams
2021-01-14 1:49 ` HORIGUCHI NAOYA(堀口 直也)
2021-01-14 6:18 ` Dan Williams
2021-01-14 6:30 ` Oscar Salvador [this message]
2021-01-14 7:10 ` HORIGUCHI NAOYA(堀口 直也)
2021-01-17 22:01 ` Andrew Morton
2021-01-17 22:35 ` Dan Williams
2021-01-14 0:43 ` [PATCH v4 5/5] mm: Fix memory_failure() handling of dax-namespace metadata Dan Williams
2021-01-14 2:25 ` HORIGUCHI NAOYA(堀口 直也)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c470b3d344e560e5c1c7b57f9bf83a37@suse.de \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mhocko@kernel.org \
--cc=nao.horiguchi@gmail.com \
--cc=naoya.horiguchi@nec.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).