From: Ralph Campbell <rcampbell@nvidia.com>
To: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>,
<dan.j.williams@intel.com>, <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-nvdimm@lists.01.org
Subject: Re: [PATCH v6] mm/pgmap: Use correct alignment when looking at first pfn from a region
Date: Tue, 17 Sep 2019 14:57:47 -0700 [thread overview]
Message-ID: <c7a444fd-d000-27f1-1e03-8ca969ee794b@nvidia.com> (raw)
In-Reply-To: <20190917153129.12905-1-aneesh.kumar@linux.ibm.com>
On 9/17/19 8:31 AM, Aneesh Kumar K.V wrote:
> vmem_altmap_offset() adjust the section aligned base_pfn offset.
> So we need to make sure we account for the same when computing base_pfn.
>
> ie, for altmap_valid case, our pfn_first should be:
>
> pfn_first = altmap->base_pfn + vmem_altmap_offset(altmap);
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> ---
> * changes from v5
> * update commit subject and use linux-mm for merge
>
> mm/memremap.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/mm/memremap.c b/mm/memremap.c
> index ed70c4e8e52a..233908d7df75 100644
> --- a/mm/memremap.c
> +++ b/mm/memremap.c
> @@ -54,8 +54,16 @@ static void pgmap_array_delete(struct resource *res)
>
> static unsigned long pfn_first(struct dev_pagemap *pgmap)
> {
> - return PHYS_PFN(pgmap->res.start) +
> - vmem_altmap_offset(pgmap_altmap(pgmap));
> + const struct resource *res = &pgmap->res;
> + struct vmem_altmap *altmap = pgmap_altmap(pgmap);
> + unsigned long pfn;
> +
> + if (altmap) {
> + pfn = altmap->base_pfn + vmem_altmap_offset(altmap);
> + } else
A nit: you don't need the '{}'s
> + pfn = PHYS_PFN(res->start);
> +
> + return pfn;
> }
>
> static unsigned long pfn_end(struct dev_pagemap *pgmap)
>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2019-09-17 21:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 15:31 [PATCH v6] mm/pgmap: Use correct alignment when looking at first pfn from a region Aneesh Kumar K.V
2019-09-17 21:57 ` Ralph Campbell [this message]
2019-09-19 19:25 ` Andrew Morton
2019-09-25 3:51 ` Aneesh Kumar K.V
2019-11-30 23:13 ` Andrew Morton
2019-12-03 0:50 ` Dan Williams
2019-12-03 10:12 ` Aneesh Kumar K.V
2020-01-31 4:26 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7a444fd-d000-27f1-1e03-8ca969ee794b@nvidia.com \
--to=rcampbell@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).