From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>
Cc: "aneesh.kumar@linux.ibm.com" <aneesh.kumar@linux.ibm.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [ndctl PATCH 2/2] ndctl/namespace: introduce ndctl_namespace_is_configurable()
Date: Mon, 4 Nov 2019 19:04:57 +0000 [thread overview]
Message-ID: <d67d153b1d5e24814087477eeabf34fe908bdf80.camel@intel.com> (raw)
In-Reply-To: <CAPcyv4i5cqOrO6LLPZ2z5xx1xApbHaSvMiNk5CCQQ0ZxOr2hCQ@mail.gmail.com>
On Mon, 2019-11-04 at 10:58 -0800, Dan Williams wrote:
> >
> > > Also, how about s/ndctl_namespace_is_configurable/ndctl_namespace_is_configuration_idle/?
> > > Because to me all namespaces are always "configurable", but some may
> > > have active non-default properties set.
> >
> > Sounds reasonable, but how about ndctl_namespace_has_partial_config(),
> > which I think describes the situation better, and makes it
> > straightforward for a potential future --really-force (or -ff) option
> > where we might still want to blow away anything on this namespace and
> > reclaim it.
>
> Does "_has_partial_config()" imply "_has_full_config()"? In other
> words, what ndctl cares about are namespaces that can effectively be
> used as seeds with no existing configuration parameters having been
> set. So "_is_configuration_idle()" seems unambiguous where
> "_has_partial_config()" does not.
Good point, I'll go with _is_configuration_idle()
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
prev parent reply other threads:[~2019-11-04 19:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 20:27 [ndctl PATCH 1/2] ndctl/namespace: remove open coded is_namespace_active() Vishal Verma
2019-11-01 20:27 ` [ndctl PATCH 2/2] ndctl/namespace: introduce ndctl_namespace_is_configurable() Vishal Verma
2019-11-04 16:35 ` Dan Williams
2019-11-04 18:48 ` Verma, Vishal L
2019-11-04 18:58 ` Dan Williams
2019-11-04 19:04 ` Verma, Vishal L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d67d153b1d5e24814087477eeabf34fe908bdf80.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).