From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3403C4360C for ; Fri, 27 Sep 2019 10:36:18 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9ED412146E for ; Fri, 27 Sep 2019 10:36:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9ED412146E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id CB0422010BD5C; Fri, 27 Sep 2019 03:38:17 -0700 (PDT) Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=aneesh.kumar@linux.ibm.com; receiver=linux-nvdimm@lists.01.org Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7ABEF2010BD51 for ; Fri, 27 Sep 2019 03:38:16 -0700 (PDT) Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x8RAVoYY103271; Fri, 27 Sep 2019 06:36:06 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 2v8w26upph-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Sep 2019 06:36:06 -0400 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.27/8.16.0.27) with SMTP id x8RAVvtg103463; Fri, 27 Sep 2019 06:36:05 -0400 Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com with ESMTP id 2v8w26uppb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Sep 2019 06:36:05 -0400 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id x8RAZ4Wr027031; Fri, 27 Sep 2019 10:36:05 GMT Received: from b01cxnp23032.gho.pok.ibm.com (b01cxnp23032.gho.pok.ibm.com [9.57.198.27]) by ppma04wdc.us.ibm.com with ESMTP id 2v5bg7y8fv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Sep 2019 10:36:05 +0000 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x8RAa4mr54591874 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 27 Sep 2019 10:36:04 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8E7F3AE05F; Fri, 27 Sep 2019 10:36:04 +0000 (GMT) Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 476C0AE05C; Fri, 27 Sep 2019 10:36:03 +0000 (GMT) Received: from [9.124.35.215] (unknown [9.124.35.215]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 27 Sep 2019 10:36:03 +0000 (GMT) Subject: Re: [PATCH 1/2] mm/memunmap: Use the correct start and end pfn when removing pages from zone To: David Hildenbrand , Andrew Morton References: <20190830091428.18399-1-david@redhat.com> <20190926122552.17905-1-aneesh.kumar@linux.ibm.com> <20190926154508.3dba3dc398b7bb9a40ba15da@linux-foundation.org> <894daaaf-ce64-c2d8-d246-5d4c5f42579d@linux.ibm.com> From: "Aneesh Kumar K.V" Message-ID: Date: Fri, 27 Sep 2019 16:06:02 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-09-27_06:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1909270098 X-BeenThere: linux-nvdimm@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Linux-nvdimm developer list." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mm@kvack.org, linux-nvdimm@lists.01.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" On 9/27/19 1:16 PM, David Hildenbrand wrote: > On 27.09.19 03:51, Aneesh Kumar K.V wrote: >> On 9/27/19 4:15 AM, Andrew Morton wrote: >>> On Thu, 26 Sep 2019 17:55:51 +0530 "Aneesh Kumar K.V" wrote: >>> >>>> With altmap, all the resource pfns are not initialized. While initializing >>>> pfn, altmap reserve space is skipped. Hence when removing pfn from zone skip >>>> pfns that were never initialized. >>>> >>>> Update memunmap_pages to calculate start and end pfn based on altmap >>>> values. This fixes a kernel crash that is observed when destroying namespace. >>>> >>>> [ 74.745056] BUG: Unable to handle kernel data access at 0xc00c000001400000 >>>> [ 74.745256] Faulting instruction address: 0xc0000000000b58b0 >>>> cpu 0x2: Vector: 300 (Data Access) at [c00000026ea93580] >>>> pc: c0000000000b58b0: memset+0x68/0x104 >>>> lr: c0000000003eb008: page_init_poison+0x38/0x50 >>>> ... >>>> current = 0xc000000271c67d80 >>>> paca = 0xc00000003fffd680 irqmask: 0x03 irq_happened: 0x01 >>>> pid = 3665, comm = ndctl >>>> [link register ] c0000000003eb008 page_init_poison+0x38/0x50 >>>> [c00000026ea93830] c0000000004754d4 remove_pfn_range_from_zone+0x64/0x3e0 >>>> [c00000026ea938a0] c0000000004b8a60 memunmap_pages+0x300/0x400 >>>> [c00000026ea93930] c0000000009e32a0 devm_action_release+0x30/0x50 >>> >>> Doesn't apply to mainline or -next. Which tree is this against? >>> >> >> After applying the patches from David on mainline. That is the reason I >> replied to this thread. I should have mentioned in the email that it is >> based on patch series "[PATCH v4 0/8] mm/memory_hotplug: Shrink zones >> before removing memory" > > So if I am not wrong, my patch "[PATCH v4 4/8] mm/memory_hotplug: Poison > memmap in remove_pfn_range_from_zone()" makes it show up that we > actually call _remove_pages() with wrong parameters, right? > > If so, I guess it would be better for you to fix it before my series and > I will rebase my series on top of that. > I posted a patch that can be applied to mainline. I sent that as a reply to this email. Can you include that and PATCH 2 as first two patches in your series? That should help to locate the full patch series needed for fixing the kernel crash. -aneesh _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm