From: David Hildenbrand <david@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>,
Pankaj Gupta <pankaj.gupta@cloud.ionos.com>
Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [RFC 0/2] virtio-pmem: Asynchronous flush
Date: Fri, 12 Mar 2021 09:53:09 +0100 [thread overview]
Message-ID: <e28be6b8-a6d4-996a-094a-830db1ab5f22@redhat.com> (raw)
In-Reply-To: <CAPcyv4i4=2zT65Ym-sQv4gSa421q7FUAcX6Un3hf8=FW5qi3yw@mail.gmail.com>
On 12.03.21 07:02, Dan Williams wrote:
> On Thu, Mar 11, 2021 at 8:21 PM Pankaj Gupta
> <pankaj.gupta@cloud.ionos.com> wrote:
>>
>> Hi David,
>>
>>>> Jeff reported preflush order issue with the existing implementation
>>>> of virtio pmem preflush. Dan suggested[1] to implement asynchronous flush
>>>> for virtio pmem using work queue as done in md/RAID. This patch series
>>>> intends to solve the preflush ordering issue and also makes the flush
>>>> asynchronous from the submitting thread POV.
>>>>
>>>> Submitting this patch series for feeback and is in WIP. I have
>>>> done basic testing and currently doing more testing.
>>>>
>>>> Pankaj Gupta (2):
>>>> pmem: make nvdimm_flush asynchronous
>>>> virtio_pmem: Async virtio-pmem flush
>>>>
>>>> drivers/nvdimm/nd_virtio.c | 66 ++++++++++++++++++++++++++----------
>>>> drivers/nvdimm/pmem.c | 15 ++++----
>>>> drivers/nvdimm/region_devs.c | 3 +-
>>>> drivers/nvdimm/virtio_pmem.c | 9 +++++
>>>> drivers/nvdimm/virtio_pmem.h | 12 +++++++
>>>> 5 files changed, 78 insertions(+), 27 deletions(-)
>>>>
>>>> [1] https://marc.info/?l=linux-kernel&m=157446316409937&w=2
>>>>
>>>
>>> Just wondering, was there any follow up of this or are we still waiting
>>> for feedback? :)
>>
>> Thank you for bringing this up.
>>
>> My apologies I could not followup on this. I have another version in my local
>> tree but could not post it as I was not sure if I solved the problem
>> correctly. I will
>> clean it up and post for feedback as soon as I can.
>>
>> P.S: Due to serious personal/family health issues I am not able to
>> devote much time
>> on this with other professional commitments. I feel bad that I have
>> this unfinished task.
>> Just in last one year things have not been stable for me & my family
>> and still not getting :(
>
> No worries Pankaj. Take care of yourself and your family. The
> community can handle this for you. I'm open to coaching somebody
> through what's involved to get this fix landed.
Absolutely, no need to worry for now - take care of yourself and your
loved ones! I was merely stumbling over this series while cleaning up my
inbox, wondering if this is still stuck waiting for review/feedback. No
need to rush anything or be stressed.
In case I have time to look into this in the future, I'd coordinate in
this thread (especially, asking for feedback again so I know where this
series stands)!
--
Thanks,
David / dhildenb
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
prev parent reply other threads:[~2021-03-12 8:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 13:19 [RFC 0/2] virtio-pmem: Asynchronous flush Pankaj Gupta
2020-04-20 13:19 ` [RFC 1/2] pmem: make nvdimm_flush asynchronous Pankaj Gupta
2020-04-20 13:19 ` [RFC 2/2] virtio_pmem: Async virtio-pmem flush Pankaj Gupta
2021-03-11 16:31 ` [RFC 0/2] virtio-pmem: Asynchronous flush David Hildenbrand
2021-03-12 4:21 ` Pankaj Gupta
2021-03-12 6:02 ` Dan Williams
2021-03-12 8:53 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e28be6b8-a6d4-996a-094a-830db1ab5f22@redhat.com \
--to=david@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mst@redhat.com \
--cc=pankaj.gupta.linux@gmail.com \
--cc=pankaj.gupta@cloud.ionos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).