Re: [ndctl RESEND PATCH v2] monitor: Add epoll timeout for forcing a full dimm health check

[Vishal Verma <vishal.l.verma@intel.com>]

On Wed, 2020-07-22 at 10:54 +0530, Vaibhav Jain wrote:
> This patch adds a new command argument to the 'monitor' command namely
> '--poll' that triggers a call to notify_dimm_event() at regular
> intervals forcing a periodic check of status/events for the nvdimm
> objects i.e. bus, dimms, regions or namespaces.
> 
> This behavior is useful for dimms that do not support event notifications
> in case the health status of an nvdimm changes. This is especially
> true in case of PAPR-SCM nvdimms as the PHYP hypervisor doesn't provide
> any notifications to the guest kernel on a change in nvdimm health
> status. In such case periodic polling of the is the only way to track
> the health of a nvdimm.
> 
> The patch updates monitor_event() adding a timeout value to
> epoll_wait() call. Also to prevent the possibility of a single dimm
> generating enough events thereby preventing check for status of other
> nvdimms objects, a 'fullpoll_ts' time-stamp is added to keep track of
> when full check of all nvdimms objects happened. If after epoll_wait()
> returns 'fullpoll_ts' time-stamp indicates last a full status check
> for nvdimm objects happened beyond 'poll-interval' seconds then a full
> status check is enforced.
> 
> Cc: QI Fuli <qi.fuli@jp.fujitsu.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
> ---
> Changelog:
> 
> Resend
> * None
> 
Hi Vaibhav,

I do have this queued up in my staging branch, I've just yet to push it out :)

Thanks for the ping!
-Vishal


_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org