Linux-NVDIMM Archive on lore.kernel.org
 help / color / Atom feed
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Ira Weiny <ira.weiny@intel.com>,
	"Verma, Vishal L" <vishal.l.verma@intel.com>
Cc: "kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] bnvdimm/namsepace: Don't set claim_class on error
Date: Thu, 26 Sep 2019 09:08:14 +0200
Message-ID: <fe170e53-92d1-eca8-d419-1a4210cb7313@suse.de> (raw)
In-Reply-To: <20190925184939.GA11669@iweiny-DESK2.sc.intel.com>

On 25/09/2019 20:49, Ira Weiny wrote:
>>>
>>> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
>>> ---
>>>  drivers/nvdimm/namespace_devs.c | 19 +++++++++----------
>>>  1 file changed, 9 insertions(+), 10 deletions(-)
>>
>> One minor nit below, but otherwise it looks good to me:
>> Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>

Another minor nit, the Subject says:
"bnvdimm/namsepace: Don't set claim_class on error"

a.k.a missing the 'li' part of libnvdimm

-- 
Johannes Thumshirn                            SUSE Labs Filesystems
jthumshirn@suse.de                                +49 911 74053 689
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5
90409 Nürnberg
Germany
(HRB 247165, AG München)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-25 18:10 ira.weiny
2019-09-25 18:36 ` Verma, Vishal L
2019-09-25 18:49   ` Ira Weiny
2019-09-26  7:08     ` Johannes Thumshirn [this message]
2019-09-26 16:05       ` Weiny, Ira

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe170e53-92d1-eca8-d419-1a4210cb7313@suse.de \
    --to=jthumshirn@suse.de \
    --cc=ira.weiny@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NVDIMM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nvdimm/0 linux-nvdimm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvdimm linux-nvdimm/ https://lore.kernel.org/linux-nvdimm \
		linux-nvdimm@lists.01.org
	public-inbox-index linux-nvdimm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.01.lists.linux-nvdimm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git