Linux-NVDIMM Archive on lore.kernel.org
 help / color / Atom feed
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
	"Weiny, Ira" <ira.weiny@intel.com>
Cc: "kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] bnvdimm/namsepace: Don't set claim_class on error
Date: Wed, 25 Sep 2019 18:36:35 +0000
Message-ID: <ff7ff4f5b4289d189a7c347591a5c35876ea804f.camel@intel.com> (raw)
In-Reply-To: <20190925181056.11097-1-ira.weiny@intel.com>

On Wed, 2019-09-25 at 11:10 -0700, ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com>
> 
> Don't leave claim_class set to an invalid value if an error occurs in
> btt_claim_class().
> 
> While we are here change the return type of __holder_class_store() to be
> clear about the values it is returning.
> 
> This was found via code inspection.
> 
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> ---
>  drivers/nvdimm/namespace_devs.c | 19 +++++++++----------
>  1 file changed, 9 insertions(+), 10 deletions(-)

One minor nit below, but otherwise it looks good to me:
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>

> 
> diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c
> index 5b22cecefc99..a020c166e1e7 100644
> --- a/drivers/nvdimm/namespace_devs.c
> +++ b/drivers/nvdimm/namespace_devs.c
> @@ -1510,16 +1510,19 @@ static ssize_t holder_show(struct device *dev,
>  }
>  static DEVICE_ATTR_RO(holder);
>  
> -static ssize_t __holder_class_store(struct device *dev, const char *buf)
> +static int __holder_class_store(struct device *dev, const char *buf)
>  {
>  	struct nd_namespace_common *ndns = to_ndns(dev);
>  
>  	if (dev->driver || ndns->claim)
>  		return -EBUSY;
>  
> -	if (sysfs_streq(buf, "btt"))
> -		ndns->claim_class = btt_claim_class(dev);
> -	else if (sysfs_streq(buf, "pfn"))
> +	if (sysfs_streq(buf, "btt")) {
> +		int rc = btt_claim_class(dev);

Need a blank line here separating variable declarations and code.

> +		if (rc < NVDIMM_CCLASS_NONE)
> +			return rc;
> +		ndns->claim_class = rc;
> +	} else if (sysfs_streq(buf, "pfn"))
>  		ndns->claim_class = NVDIMM_CCLASS_PFN;
>  	else if (sysfs_streq(buf, "dax"))
>  		ndns->claim_class = NVDIMM_CCLASS_DAX;
> @@ -1528,10 +1531,6 @@ static ssize_t __holder_class_store(struct device *dev, const char *buf)
>  	else
>  		return -EINVAL;
>  
> -	/* btt_claim_class() could've returned an error */
> -	if ((int)ndns->claim_class < 0)
> -		return ndns->claim_class;
> -
>  	return 0;
>  }
>  
> @@ -1539,7 +1538,7 @@ static ssize_t holder_class_store(struct device *dev,
>  		struct device_attribute *attr, const char *buf, size_t len)
>  {
>  	struct nd_region *nd_region = to_nd_region(dev->parent);
> -	ssize_t rc;
> +	int rc;
>  
>  	nd_device_lock(dev);
>  	nvdimm_bus_lock(dev);
> @@ -1547,7 +1546,7 @@ static ssize_t holder_class_store(struct device *dev,
>  	rc = __holder_class_store(dev, buf);
>  	if (rc >= 0)
>  		rc = nd_namespace_label_update(nd_region, dev);
> -	dev_dbg(dev, "%s(%zd)\n", rc < 0 ? "fail " : "", rc);
> +	dev_dbg(dev, "%s(%d)\n", rc < 0 ? "fail " : "", rc);
>  	nvdimm_bus_unlock(dev);
>  	nd_device_unlock(dev);
>  

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-25 18:10 ira.weiny
2019-09-25 18:36 ` Verma, Vishal L [this message]
2019-09-25 18:49   ` Ira Weiny
2019-09-26  7:08     ` Johannes Thumshirn
2019-09-26 16:05       ` Weiny, Ira

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff7ff4f5b4289d189a7c347591a5c35876ea804f.camel@intel.com \
    --to=vishal.l.verma@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NVDIMM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nvdimm/0 linux-nvdimm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvdimm linux-nvdimm/ https://lore.kernel.org/linux-nvdimm \
		linux-nvdimm@lists.01.org
	public-inbox-index linux-nvdimm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.01.lists.linux-nvdimm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git