From: Palmer Dabbelt <palmer@dabbelt.com>
To: rppt@kernel.org
Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
luto@kernel.org, Arnd Bergmann <arnd@arndb.de>,
bp@alien8.de, catalin.marinas@arm.com, cl@linux.com,
dave.hansen@linux.intel.com, david@redhat.com,
elena.reshetova@intel.com, hpa@zytor.com, mingo@redhat.com,
jejb@linux.ibm.com, kirill@shutemov.name, willy@infradead.org,
mark.rutland@arm.com, rppt@linux.ibm.com, mtk.manpages@gmail.com,
Paul Walmsley <paul.walmsley@sifive.com>,
peterz@infradead.org, rick.p.edgecombe@intel.com, guro@fb.com,
shakeelb@google.com, shuah@kernel.org, tglx@linutronix.de,
tycho@tycho.ws, will@kernel.org, linux-api@vger.kernel.org,
linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-nvdimm@lists.01.org, linux-riscv@lists.infradead.org,
x86@kernel.org, lkp@intel.com
Subject: Re: [PATCH v15 03/11] riscv/Kconfig: make direct map manipulation options depend on MMU
Date: Tue, 26 Jan 2021 21:46:18 -0800 (PST) [thread overview]
Message-ID: <mhng-0c84abc1-8ac8-4142-be1c-a269d8b345f8@palmerdabbelt-glaptop> (raw)
In-Reply-To: <20210123110041.GE6332@kernel.org>
On Sat, 23 Jan 2021 03:00:41 PST (-0800), rppt@kernel.org wrote:
> On Fri, Jan 22, 2021 at 08:12:30PM -0800, Palmer Dabbelt wrote:
>> On Wed, 20 Jan 2021 10:06:04 PST (-0800), rppt@kernel.org wrote:
>> > From: Mike Rapoport <rppt@linux.ibm.com>
>> >
>> > ARCH_HAS_SET_DIRECT_MAP and ARCH_HAS_SET_MEMORY configuration options have
>> > no meaning when CONFIG_MMU is disabled and there is no point to enable them
>> > for the nommu case.
>> >
>> > Add an explicit dependency on MMU for these options.
>> >
>> > Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
>> > Reported-by: kernel test robot <lkp@intel.com>
>> > ---
>> > arch/riscv/Kconfig | 4 ++--
>> > 1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
>> > index d82303dcc6b6..d35ce19ab1fa 100644
>> > --- a/arch/riscv/Kconfig
>> > +++ b/arch/riscv/Kconfig
>> > @@ -25,8 +25,8 @@ config RISCV
>> > select ARCH_HAS_KCOV
>> > select ARCH_HAS_MMIOWB
>> > select ARCH_HAS_PTE_SPECIAL
>> > - select ARCH_HAS_SET_DIRECT_MAP
>> > - select ARCH_HAS_SET_MEMORY
>> > + select ARCH_HAS_SET_DIRECT_MAP if MMU
>> > + select ARCH_HAS_SET_MEMORY if MMU
>> > select ARCH_HAS_STRICT_KERNEL_RWX if MMU
>> > select ARCH_OPTIONAL_KERNEL_RWX if ARCH_HAS_STRICT_KERNEL_RWX
>> > select ARCH_OPTIONAL_KERNEL_RWX_DEFAULT
>>
>> Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com>
>> Acked-by: Palmer Dabbelt <palmerdabbelt@google.com>
>>
>> LMK if you want this to go in via the RISC-V tree, otherwise I'm going to
>> assume it's going in along with the rest of these. FWIW I see these in other
>> architectures without the MMU guard.
>
> Except arm, they all always have MMU=y and arm selects only
> ARCH_HAS_SET_MEMORY and has empty stubs for those when MMU=n.
OK, maybe I just checked ARM, then. I was just making sure.
> Indeed I might have been over zealous adding ARCH_HAS_SET_MEMORY dependency
> on MMU, as riscv also has these stubs, but I thought that making this
> explicit is a nice thing.
It seems reasonable to me.
Thanks!
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2021-01-27 5:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 18:06 [PATCH v15 00/11] mm: introduce memfd_secret system call to create "secret" memory areas Mike Rapoport
2021-01-20 18:06 ` [PATCH v15 01/11] mm: add definition of PMD_PAGE_ORDER Mike Rapoport
2021-01-20 18:06 ` [PATCH v15 02/11] mmap: make mlock_future_check() global Mike Rapoport
2021-01-20 18:06 ` [PATCH v15 03/11] riscv/Kconfig: make direct map manipulation options depend on MMU Mike Rapoport
2021-01-23 4:12 ` Palmer Dabbelt
2021-01-23 11:00 ` Mike Rapoport
2021-01-27 5:46 ` Palmer Dabbelt [this message]
2021-01-20 18:06 ` [PATCH v15 04/11] set_memory: allow set_direct_map_*_noflush() for multiple pages Mike Rapoport
2021-01-20 18:06 ` [PATCH v15 05/11] set_memory: allow querying whether set_direct_map_*() is actually enabled Mike Rapoport
2021-01-20 18:06 ` [PATCH v15 06/11] mm: introduce memfd_secret system call to create "secret" memory areas Mike Rapoport
2021-01-20 20:35 ` Matthew Wilcox
2021-01-20 21:42 ` Mike Rapoport
2021-01-20 18:06 ` [PATCH v15 07/11] secretmem: use PMD-size pages to amortize direct map fragmentation Mike Rapoport
2021-01-21 0:12 ` Matthew Wilcox
2021-01-20 18:06 ` [PATCH v15 08/11] secretmem: add memcg accounting Mike Rapoport
2021-01-20 18:06 ` [PATCH v15 09/11] PM: hibernate: disable when there are active secretmem users Mike Rapoport
2021-01-20 18:06 ` [PATCH v15 10/11] arch, mm: wire up memfd_secret system call where relevant Mike Rapoport
2021-01-20 18:06 ` [PATCH v15 11/11] secretmem: test: add basic selftest for memfd_secret(2) Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-0c84abc1-8ac8-4142-be1c-a269d8b345f8@palmerdabbelt-glaptop \
--to=palmer@dabbelt.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=cl@linux.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=elena.reshetova@intel.com \
--cc=guro@fb.com \
--cc=hpa@zytor.com \
--cc=jejb@linux.ibm.com \
--cc=kirill@shutemov.name \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mtk.manpages@gmail.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=rppt@kernel.org \
--cc=rppt@linux.ibm.com \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tycho@tycho.ws \
--cc=viro@zeniv.linux.org.uk \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).