From: Jeff Moyer <jmoyer@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org
Subject: Re: [PATCH v2 0/3] libnvdimm/security: Enumerate the frozen state and other cleanups
Date: Wed, 28 Aug 2019 13:57:43 -0400 [thread overview]
Message-ID: <x4936hl8960.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <156686728950.184120.5188743631586996901.stgit@dwillia2-desk3.amr.corp.intel.com> (Dan Williams's message of "Mon, 26 Aug 2019 17:54:49 -0700")
Dan Williams <dan.j.williams@intel.com> writes:
> Changes since v1 [1]:
> - Cleanup patch1, simplify flags return in the overwrite case and
> consolidate frozen-state cases (Jeff)
> - Clarify the motivation for patch2 (Jeff)
> - Collect Dave's Reviewed-by
The series tests out fine for me.
Thanks, Dan!
-Jeff
>
> [1]: https://lists.01.org/pipermail/linux-nvdimm/2019-August/023133.html
>
> ---
>
> Jeff reported a scenario where ndctl was failing to unlock DIMMs [2].
> Through the course of debug it was discovered that the security
> interface on the DIMMs was in the 'frozen' state disallowing unlock, or
> any security operation. Unfortunately the kernel only showed that the
> DIMMs were 'locked', not 'locked' and 'frozen'.
>
> Introduce a new sysfs 'frozen' attribute so that ndctl can reflect the
> "security-operations-allowed" state independently of the lock status.
> Then, followup with cleanups related to replacing a security-state-enum
> with a set of flags.
>
> [2]: https://lists.01.org/pipermail/linux-nvdimm/2019-August/022856.html
>
> ---
>
> Dan Williams (3):
> libnvdimm/security: Introduce a 'frozen' attribute
> libnvdimm/security: Tighten scope of nvdimm->busy vs security operations
> libnvdimm/security: Consolidate 'security' operations
>
>
> drivers/acpi/nfit/intel.c | 59 ++++++-----
> drivers/nvdimm/bus.c | 2
> drivers/nvdimm/dimm_devs.c | 134 ++++++--------------------
> drivers/nvdimm/nd-core.h | 51 ++++------
> drivers/nvdimm/security.c | 199 +++++++++++++++++++++++++-------------
> include/linux/libnvdimm.h | 9 +-
> tools/testing/nvdimm/dimm_devs.c | 19 +---
> 7 files changed, 226 insertions(+), 247 deletions(-)
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2019-08-28 17:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 0:54 [PATCH v2 0/3] libnvdimm/security: Enumerate the frozen state and other cleanups Dan Williams
2019-08-27 0:54 ` [PATCH v2 1/3] libnvdimm/security: Introduce a 'frozen' attribute Dan Williams
2019-08-28 17:56 ` Jeff Moyer
2019-08-27 0:55 ` [PATCH v2 2/3] libnvdimm/security: Tighten scope of nvdimm->busy vs security operations Dan Williams
2019-08-28 17:57 ` Jeff Moyer
2019-08-27 0:55 ` [PATCH v2 3/3] libnvdimm/security: Consolidate 'security' operations Dan Williams
2019-08-28 17:57 ` Jeff Moyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x4936hl8960.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).