From: Jeff Moyer <jmoyer@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>,
linux-nvdimm@lists.01.org
Subject: Re: [PATCH 00/13] nvdimm: Use more common kernel coding style
Date: Thu, 12 Sep 2019 10:00:10 -0400 [thread overview]
Message-ID: <x498sqtvclx.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <cover.1568256705.git.joe@perches.com> (Joe Perches's message of "Wed, 11 Sep 2019 19:54:30 -0700")
Joe Perches <joe@perches.com> writes:
> Rather than have a local coding style, use the typical kernel style.
The coding style isn't that different from the core kernel, and it's
still quite readable. I'd rather avoid the churn and the risk of
introducing regressions. This will also make backports to stable more
of a pain, so it isn't without cost. Dan, is this really something you
want to do?
-Jeff
>
> Joe Perches (13):
> nvdimm: Use more typical whitespace
> nvdimm: Move logical continuations to previous line
> nvdimm: Use octal permissions
> nvdimm: Use a more common kernel spacing style
> nvdimm: Use "unsigned int" in preference to "unsigned"
> nvdimm: Add and remove blank lines
> nvdimm: Use typical kernel brace styles
> nvdimm: Use typical kernel style indentation
> nvdimm: btt.h: Neaten #defines to improve readability
> nvdimm: namespace_devs: Move assignment operators
> nvdimm: Use more common logic testing styles and bare ; positions
> nvdimm: namespace_devs: Change progess typo to progress
> nvdimm: Miscellaneous neatening
>
> drivers/nvdimm/badrange.c | 22 +-
> drivers/nvdimm/blk.c | 39 ++--
> drivers/nvdimm/btt.c | 249 +++++++++++----------
> drivers/nvdimm/btt.h | 56 ++---
> drivers/nvdimm/btt_devs.c | 68 +++---
> drivers/nvdimm/bus.c | 138 ++++++------
> drivers/nvdimm/claim.c | 50 ++---
> drivers/nvdimm/core.c | 42 ++--
> drivers/nvdimm/dax_devs.c | 3 +-
> drivers/nvdimm/dimm.c | 3 +-
> drivers/nvdimm/dimm_devs.c | 107 ++++-----
> drivers/nvdimm/e820.c | 2 +-
> drivers/nvdimm/label.c | 213 +++++++++---------
> drivers/nvdimm/label.h | 6 +-
> drivers/nvdimm/namespace_devs.c | 472 +++++++++++++++++++++-------------------
> drivers/nvdimm/nd-core.h | 31 +--
> drivers/nvdimm/nd.h | 94 ++++----
> drivers/nvdimm/nd_virtio.c | 20 +-
> drivers/nvdimm/of_pmem.c | 6 +-
> drivers/nvdimm/pfn_devs.c | 136 ++++++------
> drivers/nvdimm/pmem.c | 57 ++---
> drivers/nvdimm/pmem.h | 2 +-
> drivers/nvdimm/region.c | 20 +-
> drivers/nvdimm/region_devs.c | 160 +++++++-------
> drivers/nvdimm/security.c | 138 ++++++------
> drivers/nvdimm/virtio_pmem.c | 10 +-
> 26 files changed, 1115 insertions(+), 1029 deletions(-)
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2019-09-12 14:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 2:54 [PATCH 00/13] nvdimm: Use more common kernel coding style Joe Perches
2019-09-12 2:54 ` [PATCH 01/13] nvdimm: Use more typical whitespace Joe Perches
2019-09-12 12:17 ` Christoph Hellwig
2019-09-12 15:01 ` Joe Perches
2019-09-16 7:07 ` Christoph Hellwig
2019-09-12 2:54 ` [PATCH 02/13] nvdimm: Move logical continuations to previous line Joe Perches
2019-09-12 2:54 ` [PATCH 03/13] nvdimm: Use octal permissions Joe Perches
2019-09-12 2:54 ` [PATCH 04/13] nvdimm: Use a more common kernel spacing style Joe Perches
2019-09-12 2:54 ` [PATCH 05/13] nvdimm: Use "unsigned int" in preference to "unsigned" Joe Perches
2019-09-12 2:54 ` [PATCH 06/13] nvdimm: Add and remove blank lines Joe Perches
2019-09-12 2:54 ` [PATCH 07/13] nvdimm: Use typical kernel brace styles Joe Perches
2019-09-12 2:54 ` [PATCH 08/13] nvdimm: Use typical kernel style indentation Joe Perches
2019-09-12 2:54 ` [PATCH 09/13] nvdimm: btt.h: Neaten #defines to improve readability Joe Perches
2019-09-12 2:54 ` [PATCH 10/13] nvdimm: namespace_devs: Move assignment operators Joe Perches
2019-09-12 2:54 ` [PATCH 11/13] nvdimm: Use more common logic testing styles and bare ; positions Joe Perches
2019-09-12 3:52 ` Verma, Vishal L
2019-09-12 2:54 ` [PATCH 12/13] nvdimm: namespace_devs: Change progess typo to progress Joe Perches
2019-09-12 2:54 ` [PATCH 13/13] nvdimm: Miscellaneous neatening Joe Perches
2019-09-12 8:00 ` [PATCH 00/13] nvdimm: Use more common kernel coding style Dan Williams
2019-09-12 8:15 ` Joe Perches
2019-09-12 8:42 ` Miguel Ojeda
2019-09-12 14:00 ` Jeff Moyer [this message]
2019-09-12 14:06 ` Johannes Thumshirn
2019-09-12 14:35 ` Dan Williams
2019-09-12 14:21 ` Miguel Ojeda
2019-09-12 21:08 ` Joe Perches
2019-09-12 21:58 ` Miguel Ojeda
2019-09-12 22:15 ` Joe Perches
2019-09-12 22:38 ` Joe Perches
2019-09-12 23:00 ` Nick Desaulniers
2019-09-12 23:07 ` Joe Perches
2019-09-12 22:58 ` Nick Desaulniers
2019-09-12 23:26 ` clang-format and 'clang-format on' and 'clang-format off' Joe Perches
2019-09-15 18:25 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x498sqtvclx.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).