From: Jeff Moyer <jmoyer@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH] virtio pmem: fix async flush ordering
Date: Fri, 22 Nov 2019 11:25:11 -0500 [thread overview]
Message-ID: <x49d0djev4o.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <CAPcyv4idC=LgkwP+A1GKJ1CWkzUZ_RVBDCVfA3yAL9TNw1zZmw@mail.gmail.com> (Dan Williams's message of "Fri, 22 Nov 2019 08:13:05 -0800")
Dan Williams <dan.j.williams@intel.com> writes:
> On Fri, Nov 22, 2019 at 8:09 AM Jeff Moyer <jmoyer@redhat.com> wrote:
>>
>> Dan Williams <dan.j.williams@intel.com> writes:
>>
>> > On Wed, Nov 20, 2019 at 9:26 AM Jeff Moyer <jmoyer@redhat.com> wrote:
>> >>
>> >> Pankaj Gupta <pagupta@redhat.com> writes:
>> >>
>> >> > Remove logic to create child bio in the async flush function which
>> >> > causes child bio to get executed after parent bio 'pmem_make_request'
>> >> > completes. This resulted in wrong ordering of REQ_PREFLUSH with the
>> >> > data write request.
>> >> >
>> >> > Instead we are performing flush from the parent bio to maintain the
>> >> > correct order. Also, returning from function 'pmem_make_request' if
>> >> > REQ_PREFLUSH returns an error.
>> >> >
>> >> > Reported-by: Jeff Moyer <jmoyer@redhat.com>
>> >> > Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
>> >>
>> >> There's a slight change in behavior for the error path in the
>> >> virtio_pmem driver. Previously, all errors from virtio_pmem_flush were
>> >> converted to -EIO. Now, they are reported as-is. I think this is
>> >> actually an improvement.
>> >>
>> >> I'll also note that the current behavior can result in data corruption,
>> >> so this should be tagged for stable.
>> >
>> > I added that and was about to push this out, but what about the fact
>> > that now the guest will synchronously wait for flushing to occur. The
>> > goal of the child bio was to allow that to be an I/O wait with
>> > overlapping I/O, or at least not blocking the submission thread. Does
>> > the block layer synchronously wait for PREFLUSH requests?
>>
>> You *have* to wait for the preflush to complete before issuing the data
>> write. See the "Explicit cache flushes" section in
>> Documentation/block/writeback_cache_control.rst.
>
> I'm not debating the ordering, or that the current implementation is
> obviously broken. I'm questioning whether the bio tagged with PREFLUSH
> is a barrier for future I/Os. My reading is that it is only a gate for
> past writes, and it can be queued. I.e. along the lines of
> md_flush_request().
Sorry, I misunderstood your question.
For a write bio with REQ_PREFLUSH set, the PREFLUSH has to be done
before the data attached to the bio is written. That preflush is not an
I/O barrier. In other words, for unrelated I/O (any other bio in the
system), it does not impart any specific ordering requirements. Upper
layers are expected to wait for any related I/O completions before
issuing a flush request.
So yes, you can queue the bio to a worker thread and return to the
caller. In fact, this is what I had originally suggested to Pankaj.
Cheers,
Jeff
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
prev parent reply other threads:[~2019-11-22 16:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 9:28 [PATCH] virtio pmem: fix async flush ordering Pankaj Gupta
2019-11-20 17:26 ` Jeff Moyer
2019-11-21 6:44 ` Pankaj Gupta
2019-11-21 7:23 ` Dan Williams
2019-11-21 7:32 ` Dan Williams
2019-11-21 8:00 ` Pankaj Gupta
2019-11-21 16:09 ` Dan Williams
2019-11-22 4:38 ` Pankaj Gupta
2019-11-22 5:17 ` Dan Williams
2019-11-22 5:37 ` Pankaj Gupta
2019-11-22 22:52 ` Dan Williams
2019-11-21 8:01 ` Pankaj Gupta
2019-11-22 16:08 ` Jeff Moyer
2019-11-22 16:13 ` Dan Williams
2019-11-22 16:25 ` Jeff Moyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49d0djev4o.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).