From: Jeff Moyer <jmoyer@redhat.com> To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> Cc: linux-nvdimm@lists.01.org Subject: Re: [RFC PATCH] libnvdimm: Update the meaning for persistence_domain values Date: Wed, 15 Jan 2020 12:35:40 -0500 Message-ID: <x49k15soc5v.fsf@segfault.boston.devel.redhat.com> (raw) In-Reply-To: <a87b5da8-54d1-3c1a-f068-4d2f389576c9@linux.ibm.com> (Aneesh Kumar K. V.'s message of "Wed, 15 Jan 2020 22:57:00 +0530") "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> writes: >> Would you also update of_pmem to indicate the persistence domain, >> please? >> > > sure. Thanks! >>> diff --git a/include/linux/libnvdimm.h b/include/linux/libnvdimm.h >>> index f2a33f2e3ba8..9126737377e1 100644 >>> --- a/include/linux/libnvdimm.h >>> +++ b/include/linux/libnvdimm.h >>> @@ -52,9 +52,9 @@ enum { >>> */ >>> ND_REGION_PERSIST_CACHE = 1, >>> /* >>> - * Platform provides mechanisms to automatically flush outstanding >>> - * write data from memory controler to pmem on system power loss. >>> - * (ADR) >>> + * Platform provides instructions to flush data such that on completion >>> + * of the instructions, data flushed is guaranteed to be on pmem even >>> + * in case of a system power loss. >> >> I find the prior description easier to understand. > > I was trying to avoid the term 'automatically, 'memory controler' and > ADR. Can I update the above as I can understand avoiding the very x86-specific "ADR," but is memory controller not accurate for your platform? > /* > * Platform provides mechanisms to flush outstanding write data > * to pmem on system power loss. > */ That's way too broad. :) The comments are describing the persistence domain. i.e. if you get data to $HERE, it is guaranteed to make it out to stable media. -Jeff _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply index Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-08 6:49 Aneesh Kumar K.V 2020-01-15 16:55 ` Jeff Moyer 2020-01-15 17:27 ` Aneesh Kumar K.V 2020-01-15 17:31 ` Aneesh Kumar K.V 2020-01-15 17:42 ` Jeff Moyer 2020-01-15 19:44 ` Dan Williams 2020-01-15 17:35 ` Jeff Moyer [this message] 2020-01-15 17:55 ` Aneesh Kumar K.V 2020-01-15 19:48 ` Dan Williams 2020-01-16 6:24 ` Aneesh Kumar K.V
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=x49k15soc5v.fsf@segfault.boston.devel.redhat.com \ --to=jmoyer@redhat.com \ --cc=aneesh.kumar@linux.ibm.com \ --cc=linux-nvdimm@lists.01.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-NVDIMM Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-nvdimm/0 linux-nvdimm/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-nvdimm linux-nvdimm/ https://lore.kernel.org/linux-nvdimm \ linux-nvdimm@lists.01.org public-inbox-index linux-nvdimm Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.01.lists.linux-nvdimm AGPL code for this site: git clone https://public-inbox.org/public-inbox.git