From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 170F020213F07 for ; Thu, 22 Aug 2019 13:42:26 -0700 (PDT) From: Jeff Moyer Subject: Re: [ndctl PATCH 2/2] libdaxctl: point to migrate-device-model for dax-class errors References: <20190822203635.17926-1-vishal.l.verma@intel.com> <20190822203635.17926-2-vishal.l.verma@intel.com> Date: Thu, 22 Aug 2019 16:41:23 -0400 In-Reply-To: <20190822203635.17926-2-vishal.l.verma@intel.com> (Vishal Verma's message of "Thu, 22 Aug 2019 14:36:35 -0600") Message-ID: MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Vishal Verma Cc: Dave Hansen , linux-nvdimm@lists.01.org List-ID: Vishal Verma writes: > When a dax-bus vs. dax-class expectation causes a failure, such as when > reconfiguring device modes, print an error message directly pointing the > user to the daxctl-migrate-device-model command. > > Reported-by: Dave Hansen > Reported-by: Jeff Moyer > Cc: Dan Williams > Signed-off-by: Vishal Verma > --- > daxctl/lib/libdaxctl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/daxctl/lib/libdaxctl.c b/daxctl/lib/libdaxctl.c > index 44842b9..c0a859c 100644 > --- a/daxctl/lib/libdaxctl.c > +++ b/daxctl/lib/libdaxctl.c > @@ -917,6 +917,7 @@ static int daxctl_dev_enable(struct daxctl_dev *dev, enum daxctl_dev_mode mode) > > if (!device_model_is_dax_bus(dev)) { > err(ctx, "%s: error: device model is dax-class\n", devname); > + err(ctx, "%s: see man daxctl-migrate-device-model\n", devname); > return -EOPNOTSUPP; > } > > @@ -962,6 +963,7 @@ DAXCTL_EXPORT int daxctl_dev_disable(struct daxctl_dev *dev) > > if (!device_model_is_dax_bus(dev)) { > err(ctx, "%s: error: device model is dax-class\n", devname); > + err(ctx, "%s: see man daxctl-migrate-device-model\n", devname); > return -EOPNOTSUPP; > } Reviewed-by: Jeff Moyer Thanks, Vishal! _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm