From: Jeff Moyer <jmoyer@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [ndctl PATCH 1/2] ndctl/region: Support ndctl_region_{get, set}_align()
Date: Wed, 26 Feb 2020 16:52:21 -0500 [thread overview]
Message-ID: <x49y2sp3tka.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <CAPcyv4izzfzrb2r7Mc7FfryGnBcn1bOUA8a6_L9t2fKR4caoXw@mail.gmail.com> (Dan Williams's message of "Tue, 25 Feb 2020 15:23:47 -0800")
Dan Williams <dan.j.williams@intel.com> writes:
>> Missing doctext. Specifically, there should be a big, fat warning
>> against changing the region alignment.
>
> I don't mind adding one, but is this the right place to document an
> API warning? If the audience is future ndctl developers that should be
> warned to keep the status quo of not plumbing this capability into
> "create-namespace" that's one message. If it's to stop other libndctl
> application developers, they'll likely never see this source file.
I meant to target users of the library (not ndctl developers). I
thought that was the reason for the doctext on exported interfaces. No?
I admit, I don't know how users of libndctl figure *anything* out about
how to use it. :)
-Jeff
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2020-02-26 21:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 22:42 [ndctl PATCH 0/2] ndctl: Cross-arch compatible namespace alignment Dan Williams
2020-01-30 22:42 ` [ndctl PATCH 1/2] ndctl/region: Support ndctl_region_{get, set}_align() Dan Williams
2020-02-19 18:03 ` Jeff Moyer
2020-02-25 23:23 ` Dan Williams
2020-02-26 17:49 ` Dan Williams
2020-02-26 21:52 ` Jeff Moyer [this message]
2020-02-26 22:20 ` Dan Williams
2020-02-26 22:44 ` Jeff Moyer
2020-01-30 22:42 ` [ndctl PATCH 2/2] ndctl/namespace: Improve namespace action failure messages Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49y2sp3tka.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).