Re: nvme-cli spdk plugin

[Hannes Reinecke <hare@suse.de>]

On 4/17/24 16:31, Jens Axboe wrote:
> On 4/17/24 8:26 AM, Christoph Hellwig wrote:
>> On Wed, Apr 17, 2024 at 10:33:17AM +0200, Daniel Wagner wrote:
>>> There is a PR [1] pending, adding a spdk plugin for nvme-cli. The
>>> problem this new plugin tries to solve is, that with the recent change
>>> to use sysfs only for discovering the nvme subystem, nvme-cli
>>> lost support for spdk.
>>>
>>> My question is, should we have a special plugin for 'list' and
>>> 'list-subsystem' or should we try to get this somehow integrated into
>>> the existing code? So that 'list' just works?
>>
>> І don't think nvme-cli should deal with anything that is not driven
>> by the kernel nvme driver.
> 
> Exactly, why on earth would we care about spdk at all in the first
> place, nvme-cli or not.
> 

And that depends on the direction of development we want to take.
Do we want nvme-cli to become a 'general' nvme management tool, then
we should investigate in having an spdk plugin.
Or do we want to have nvme-cli as the cli for the linux nvme kernel 
driver, then clearly we wouldn't need an spdk plugin.
That, I guess, is the real discussion.

Personally I would vote for the first option. But I'm sure others have
other opinions.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich