archive mirror
 help / color / mirror / Atom feed
From: Sagi Grimberg <>
To: "Meneghini, John" <>,
	Keith Busch <>,
	"" <>,
	"" <>, Hannes Reinecke <>
Subject: Re: [PATCH] nvme: fix REQ_NVME_MPATH retry logic
Date: Fri, 13 Dec 2019 12:57:19 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

> From: John Meneghini <>
>   - Make nvme_complete_rq error handling logic
>     equivalent between single and multipath controllers.

The commit message should explain what breaks and what this
is fixing.

>   - Non-multipathing related nvme errors will
>     be retried on the same controller.

Any specific reason why we shouldn't? Or in other words,
what is the harm of doing it if we have another path?

>   - Avoid gratuitous controller reset while
>     handling BLK_STS_IOERR when REQ_NVME_MPATH is set.

This should change nvme_failover_req, not change the behavior by not
calling it. Requires an explanation what is broken with the existing

linux-nvme mailing list

      parent reply	other threads:[~2019-12-13 22:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-13  7:38 [PATCH] nvme: fix REQ_NVME_MPATH retry logic Meneghini, John
2019-12-13 13:06 ` Meneghini, John
2019-12-13 20:57 ` Sagi Grimberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).