Linux-NVME Archive on lore.kernel.org
 help / color / Atom feed
From: Victor Gladkov <Victor.Gladkov@kioxia.com>
To: Hannes Reinecke <hare@suse.de>, Sagi Grimberg <sagi@grimberg.me>,
	"James Smart" <james.smart@broadcom.com>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"james.smart@broadcom.com" <james.smart@broadcom.com>
Subject: RE: [PATCH] nvme-fabrics: reject I/O to offline device
Date: Sun, 15 Dec 2019 12:33:58 +0000
Message-ID: <1d04ad0c20b9441b839e764666060213@kioxia.com> (raw)
In-Reply-To: <e009d8fe-74ec-8c87-30ec-b1ac657b2aa8@suse.de>


On 12/9/19 17:30 PM, Victor Gladkov wrote:
> 
> On 12/8/19 14:18 PM, Hannes Reinecke wrote:
> >
> > On 12/6/19 11:18 PM, Sagi Grimberg wrote:
> > >
...............................................
> > > I think we need a fail_fast_tmo set in when establishing the
> > > controller to get it right.
> > >
> > Agreed. This whole patch looks like someone is trying to reimplement
> > fast_io_fail_tmo / dev_loss_tmo.
> > As we're moving into unreliable fabrics I guess we'll need a similar
> mechanism.
> >
> > Cheers,
> >
> > Hannes
> 
> 
> Following your suggestions, I added a new session parameter called
> "fast_fail_tmo".
> The timeout is measured in seconds from the controller reconnect, any
> command beyond that timeout is rejected.
> The new parameter value may be passed during ‘connect’, and its default
> value is 30 seconds.
> A value of -1 means no timeout (in similar to current behavior).
> 
> ---
> Regards,
> Victor

James, Hannes & Sagi. 
Can you please review last proposed patch?

Regards,
Victor
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

      parent reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-01  7:59 Victor Gladkov
2019-12-02 22:26 ` Chaitanya Kulkarni
2019-12-02 22:47 ` James Smart
2019-12-03 10:04   ` Victor Gladkov
2019-12-03 16:19     ` James Smart
2019-12-04  8:28       ` Victor Gladkov
2019-12-06  0:38         ` James Smart
2019-12-06 22:18           ` Sagi Grimberg
2019-12-08 12:31             ` Hannes Reinecke
2019-12-09 15:30               ` Victor Gladkov
2019-12-17 18:03                 ` James Smart
2019-12-17 21:46                 ` Sagi Grimberg
2019-12-18 22:20                   ` James Smart
2019-12-15 12:33               ` Victor Gladkov [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d04ad0c20b9441b839e764666060213@kioxia.com \
    --to=victor.gladkov@kioxia.com \
    --cc=hare@suse.de \
    --cc=james.smart@broadcom.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NVME Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nvme/0 linux-nvme/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvme linux-nvme/ https://lore.kernel.org/linux-nvme \
		linux-nvme@lists.infradead.org
	public-inbox-index linux-nvme

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-nvme


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git