From: sgruszka@redhat.com (Stanislaw Gruszka)
Subject: [PATCH] iommu/amd: fix sg->dma_address for sg->offset bigger than PAGE_SIZE
Date: Tue, 12 Mar 2019 08:08:33 +0100 [thread overview]
Message-ID: <20190312070832.GA2483@redhat.com> (raw)
In-Reply-To: <e0630ae9d9bee73d8a1ce3499ea9f77900e9cdfa.camel@linux.intel.com>
On Mon, Mar 11, 2019@08:47:44AM -0700, Alexander Duyck wrote:
> > drivers/iommu/amd_iommu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
> > index 6b0760dafb3e..949621f33624 100644
> > --- a/drivers/iommu/amd_iommu.c
> > +++ b/drivers/iommu/amd_iommu.c
> > @@ -2604,7 +2604,7 @@ static int map_sg(struct device *dev, struct scatterlist *sglist,
> >
> > /* Everything is mapped - write the right values into s->dma_address */
> > for_each_sg(sglist, s, nelems, i) {
> > - s->dma_address += address + s->offset;
> > + s->dma_address += address + (s->offset & ~PAGE_MASK);
> > s->dma_length = s->length;
> > }
> >
>
> You should add a comment calling out that this is needed because the
> sg_phys(s) call above this is masked with PAGE_MASK. Then this makes
> much more sense. Otherwise I would have assumed you needed either the
> full offset or none.
Would something like this
/*
* Everything is mapped - write the right values into s->dma_address.
* Take into account s->offset can be bigger than page size and sg_phys(s)
* address has to be aligned to page granularity.
*/
be appropriate ?
Stanislaw
next prev parent reply other threads:[~2019-03-12 7:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190226100535.GA20740@8bytes.org>
[not found] ` <20190226103450.GA2989@redhat.com>
[not found] ` <20190226104413.GH20740@8bytes.org>
[not found] ` <20190226112407.GB2989@redhat.com>
[not found] ` <20190228090411.GA24938@redhat.com>
[not found] ` <20190228104223.GA2749@redhat.com>
[not found] ` <20190228121948.GD6072@redhat.com>
[not found] ` <20190228134029.GC1594@8bytes.org>
[not found] ` <20190304071037.GA2787@redhat.com>
[not found] ` <CAKxU2N-k-9DCYBv6W3CohL963dr3AeY3VHyt8FrUuo=BfacDsw@mail.gmail.com>
2019-03-11 8:43 ` MT76x2U crashes XHCI driver on AMD Ryzen system Stanislaw Gruszka
2019-03-11 9:03 ` [PATCH] iommu/amd: fix sg->dma_address for sg->offset bigger than PAGE_SIZE Stanislaw Gruszka
2019-03-11 15:47 ` Alexander Duyck
2019-03-12 7:08 ` Stanislaw Gruszka [this message]
2019-03-12 15:18 ` Alexander Duyck
2019-03-13 9:03 ` [PATCH v2] " Stanislaw Gruszka
2019-03-18 10:17 ` Joerg Roedel
2019-03-12 7:13 ` MT76x2U crashes XHCI driver on AMD Ryzen system Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312070832.GA2483@redhat.com \
--to=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).