From: hare@suse.de (Hannes Reinecke)
Subject: [PATCH] nvme: Return BLK_STS_TARGET if the DNR bit is set
Date: Tue, 6 Aug 2019 13:10:36 +0200 [thread overview]
Message-ID: <20190806111036.113233-1-hare@suse.de> (raw)
If the DNR bit is set we should not retry the command, even if
the standard status evaluation indicates so.
Signed-off-by: Hannes Reinecke <hare at suse.com>
---
drivers/nvme/host/core.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index cc09b81fc7f4..c3e9254f4757 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -279,6 +279,13 @@ void nvme_complete_rq(struct request *req)
return;
}
}
+ /*
+ * Any pathing error might be retried, but the DNR bit takes
+ * precedence. So return BLK_STS_TARGET if the DNR bit is set
+ * to avoid retrying.
+ */
+ if (blk_path_error(status) && nvme_req(req)->status & NVME_SC_DNR)
+ status = BLK_STS_TARGET;
blk_mq_end_request(req, status);
}
EXPORT_SYMBOL_GPL(nvme_complete_rq);
--
2.16.4
next reply other threads:[~2019-08-06 11:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 11:10 Hannes Reinecke [this message]
2019-08-06 13:50 ` [PATCH] nvme: Return BLK_STS_TARGET if the DNR bit is set Nadolski, Edmund
2019-08-06 13:53 ` Hannes Reinecke
2019-08-06 14:07 ` Keith Busch
2019-08-06 14:13 ` Hannes Reinecke
2019-08-06 14:29 ` Keith Busch
2019-08-06 14:35 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806111036.113233-1-hare@suse.de \
--to=hare@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).