From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH v6 5/7] nvme-tcp: fail command with NVME_SC_HOST_PATH_ERROR send failed
Date: Mon, 12 Aug 2019 23:43:02 -0700 [thread overview]
Message-ID: <20190813064304.7344-6-sagi@grimberg.me> (raw)
In-Reply-To: <20190813064304.7344-1-sagi@grimberg.me>
This is a more appropriate error status for a transport error
detected by us (the host).
Reviewed-by: Hannes Reinecke <hare at suse.com>
Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
---
drivers/nvme/host/tcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index 2de33c4c5d14..7daf39f31b08 100644
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c
@@ -842,7 +842,7 @@ static inline void nvme_tcp_done_send_req(struct nvme_tcp_queue *queue)
static void nvme_tcp_fail_request(struct nvme_tcp_request *req)
{
- nvme_tcp_end_request(blk_mq_rq_from_pdu(req), NVME_SC_DATA_XFER_ERROR);
+ nvme_tcp_end_request(blk_mq_rq_from_pdu(req), NVME_SC_HOST_PATH_ERROR);
}
static int nvme_tcp_try_send_data(struct nvme_tcp_request *req)
--
2.17.1
next prev parent reply other threads:[~2019-08-13 6:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 6:42 [PATCH v6 0/7] nvme controller reset and namespace scan work race conditions Sagi Grimberg
2019-08-13 6:42 ` [PATCH v6 1/7] nvme: fail cancelled commands with NVME_SC_HOST_PATH_ERROR Sagi Grimberg
2019-08-15 21:03 ` James Smart
2019-08-13 6:42 ` [PATCH v6 2/7] nvme: return a proper status for sync commands failure Sagi Grimberg
2019-08-13 7:09 ` Hannes Reinecke
2019-08-15 21:05 ` James Smart
2019-08-13 6:43 ` [PATCH v6 3/7] nvme: make nvme_identify_ns propagate errors back Sagi Grimberg
2019-08-15 21:10 ` James Smart
2019-08-13 6:43 ` [PATCH v6 4/7] nvme: make nvme_report_ns_ids propagate error back Sagi Grimberg
2019-08-15 21:11 ` James Smart
2019-08-13 6:43 ` Sagi Grimberg [this message]
2019-08-15 21:11 ` [PATCH v6 5/7] nvme-tcp: fail command with NVME_SC_HOST_PATH_ERROR send failed James Smart
2019-08-13 6:43 ` [PATCH v6 6/7] nvme-fc: Fail transport errors with NVME_SC_HOST_PATH Sagi Grimberg
2019-08-15 21:12 ` James Smart
2019-08-13 6:43 ` [PATCH v6 7/7] nvme: fix ns removal hang when failing to revalidate due to a transient error Sagi Grimberg
2019-08-15 21:17 ` James Smart
2019-08-15 17:45 ` [PATCH v6 0/7] nvme controller reset and namespace scan work race conditions Sagi Grimberg
2019-08-15 20:01 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813064304.7344-6-sagi@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).