Linux-NVME Archive on lore.kernel.org
 help / color / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCHv3] nvme: Return BLK_STS_TARGET if the DNR bit is set
Date: Tue, 13 Aug 2019 19:01:44 +0200
Message-ID: <20190813170144.GA10269@lst.de> (raw)
In-Reply-To: <20190812075147.79598-1-hare@suse.de>

On Mon, Aug 12, 2019@09:51:47AM +0200, Hannes Reinecke wrote:
> If the DNR bit is set we should not retry the command, even if
> the standard status evaluation indicates so.

What problem is this even trying to solve?  Nothing in the
documentation of BLK_STS_TARGET says it should be retried any more
or less than other error code.

If you really care about a retryable vs not retryable distinction
at the block layer we need to propagate the equivalent of the DNR
bit.

  parent reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-12  7:51 Hannes Reinecke
2019-08-12 23:37 ` Nadolski, Edmund
2019-08-13  6:32   ` Sagi Grimberg
2019-08-13 14:15     ` Keith Busch
2019-08-13 16:37       ` Sagi Grimberg
2019-08-13 16:56         ` Hannes Reinecke
2019-08-13 17:01 ` Christoph Hellwig [this message]
2019-08-13 17:03   ` Hannes Reinecke
2019-08-13 17:08     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190813170144.GA10269@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NVME Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nvme/0 linux-nvme/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvme linux-nvme/ https://lore.kernel.org/linux-nvme \
		linux-nvme@lists.infradead.org
	public-inbox-index linux-nvme

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-nvme


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git