archive mirror
 help / color / mirror / Atom feed
From: (Christoph Hellwig)
Subject: [PATCHv3] nvme: Return BLK_STS_TARGET if the DNR bit is set
Date: Tue, 13 Aug 2019 19:01:44 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Aug 12, 2019@09:51:47AM +0200, Hannes Reinecke wrote:
> If the DNR bit is set we should not retry the command, even if
> the standard status evaluation indicates so.

What problem is this even trying to solve?  Nothing in the
documentation of BLK_STS_TARGET says it should be retried any more
or less than other error code.

If you really care about a retryable vs not retryable distinction
at the block layer we need to propagate the equivalent of the DNR

  parent reply	other threads:[~2019-08-13 17:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-12  7:51 [PATCHv3] nvme: Return BLK_STS_TARGET if the DNR bit is set Hannes Reinecke
2019-08-12 23:37 ` Nadolski, Edmund
2019-08-13  6:32   ` Sagi Grimberg
2019-08-13 14:15     ` Keith Busch
2019-08-13 16:37       ` Sagi Grimberg
2019-08-13 16:56         ` Hannes Reinecke
2019-08-13 17:01 ` Christoph Hellwig [this message]
2019-08-13 17:03   ` Hannes Reinecke
2019-08-13 17:08     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).