* [PATCH] nvme-core: get rid of the unused variable
@ 2019-08-31 0:10 Chaitanya Kulkarni
2019-09-01 8:20 ` Max Gurtovoy
2019-09-02 16:14 ` Christoph Hellwig
0 siblings, 2 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2019-08-31 0:10 UTC (permalink / raw)
To: linux-nvme; +Cc: Chaitanya Kulkarni
This patch fixes the following compilation warning:-
drivers/nvme//host/core.c: In function ‘nvme_complete_rq’:
drivers/nvme//host/core.c:264:18: warning: unused variable ‘ns’
[-Wunused-variable]
struct nvme_ns *ns = req->q->queuedata;
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
drivers/nvme/host/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 0b1ff8d54e48..ddf99345e3d8 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -261,7 +261,6 @@ static void nvme_retry_req(struct request *req)
void nvme_complete_rq(struct request *req)
{
blk_status_t status = nvme_error_status(req);
- struct nvme_ns *ns = req->q->queuedata;
trace_nvme_complete_rq(req);
--
2.17.0
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme-core: get rid of the unused variable
2019-08-31 0:10 [PATCH] nvme-core: get rid of the unused variable Chaitanya Kulkarni
@ 2019-09-01 8:20 ` Max Gurtovoy
2019-09-02 16:14 ` Christoph Hellwig
1 sibling, 0 replies; 4+ messages in thread
From: Max Gurtovoy @ 2019-09-01 8:20 UTC (permalink / raw)
To: Chaitanya Kulkarni, linux-nvme
On 8/31/2019 3:10 AM, Chaitanya Kulkarni wrote:
> This patch fixes the following compilation warning:-
>
> drivers/nvme//host/core.c: In function ‘nvme_complete_rq’:
> drivers/nvme//host/core.c:264:18: warning: unused variable ‘ns’
> [-Wunused-variable]
> struct nvme_ns *ns = req->q->queuedata;
>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
> drivers/nvme/host/core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 0b1ff8d54e48..ddf99345e3d8 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -261,7 +261,6 @@ static void nvme_retry_req(struct request *req)
> void nvme_complete_rq(struct request *req)
> {
> blk_status_t status = nvme_error_status(req);
> - struct nvme_ns *ns = req->q->queuedata;
I can't find this code anywhere, but anyway this must go out.
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
>
> trace_nvme_complete_rq(req);
>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme-core: get rid of the unused variable
2019-08-31 0:10 [PATCH] nvme-core: get rid of the unused variable Chaitanya Kulkarni
2019-09-01 8:20 ` Max Gurtovoy
@ 2019-09-02 16:14 ` Christoph Hellwig
2019-09-04 18:27 ` Chaitanya Kulkarni
1 sibling, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2019-09-02 16:14 UTC (permalink / raw)
To: Chaitanya Kulkarni; +Cc: linux-nvme
On Fri, Aug 30, 2019 at 05:10:13PM -0700, Chaitanya Kulkarni wrote:
> void nvme_complete_rq(struct request *req)
> {
> blk_status_t status = nvme_error_status(req);
> - struct nvme_ns *ns = req->q->queuedata;
>
> trace_nvme_complete_rq(req);
I don't actually see this variable in Linus' tree or the nvme-5.4
branch, what tree is this against?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme-core: get rid of the unused variable
2019-09-02 16:14 ` Christoph Hellwig
@ 2019-09-04 18:27 ` Chaitanya Kulkarni
0 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2019-09-04 18:27 UTC (permalink / raw)
To: linux-nvme
Please ignore this, I've messed up the pull-merge, sorry for the noise.
On 9/2/19 12:14 PM, Christoph Hellwig wrote:
> On Fri, Aug 30, 2019 at 05:10:13PM -0700, Chaitanya Kulkarni wrote:
>> void nvme_complete_rq(struct request *req)
>> {
>> blk_status_t status = nvme_error_status(req);
>> - struct nvme_ns *ns = req->q->queuedata;
>>
>> trace_nvme_complete_rq(req);
> I don't actually see this variable in Linus' tree or the nvme-5.4
> branch, what tree is this against?
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-04 18:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-31 0:10 [PATCH] nvme-core: get rid of the unused variable Chaitanya Kulkarni
2019-09-01 8:20 ` Max Gurtovoy
2019-09-02 16:14 ` Christoph Hellwig
2019-09-04 18:27 ` Chaitanya Kulkarni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).