* [PATCH] nvme: include admin_q sync with nvme_sync_queues
@ 2019-09-03 20:08 Edmund Nadolski
2019-09-03 20:12 ` Keith Busch
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Edmund Nadolski @ 2019-09-03 20:08 UTC (permalink / raw)
To: linux-nvme, keith.busch
nvme_sync_queues currently syncs all namespace queues, but should
also sync the admin queue, if present.
Signed-off-by: Edmund Nadolski <edmund.nadolski@intel.com>
---
drivers/nvme/host/core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 4660505eded9..43c12f8c030f 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3974,6 +3974,9 @@ void nvme_sync_queues(struct nvme_ctrl *ctrl)
list_for_each_entry(ns, &ctrl->namespaces, list)
blk_sync_queue(ns->queue);
up_read(&ctrl->namespaces_rwsem);
+
+ if (ctrl->admin_q)
+ blk_sync_queue(ctrl->admin_q);
}
EXPORT_SYMBOL_GPL(nvme_sync_queues);
--
2.20.1
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] nvme: include admin_q sync with nvme_sync_queues
2019-09-03 20:08 [PATCH] nvme: include admin_q sync with nvme_sync_queues Edmund Nadolski
@ 2019-09-03 20:12 ` Keith Busch
2019-09-03 20:22 ` James Smart
2019-09-04 12:47 ` Christoph Hellwig
2 siblings, 0 replies; 5+ messages in thread
From: Keith Busch @ 2019-09-03 20:12 UTC (permalink / raw)
To: Edmund Nadolski; +Cc: keith.busch, linux-nvme
On Tue, Sep 03, 2019 at 02:08:47PM -0600, Edmund Nadolski wrote:
> nvme_sync_queues currently syncs all namespace queues, but should
> also sync the admin queue, if present.
>
> Signed-off-by: Edmund Nadolski <edmund.nadolski@intel.com>
Looks good to me.
Reviewed-by: Keith Busch <kbusch@kernel.org>
> ---
> drivers/nvme/host/core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 4660505eded9..43c12f8c030f 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -3974,6 +3974,9 @@ void nvme_sync_queues(struct nvme_ctrl *ctrl)
> list_for_each_entry(ns, &ctrl->namespaces, list)
> blk_sync_queue(ns->queue);
> up_read(&ctrl->namespaces_rwsem);
> +
> + if (ctrl->admin_q)
> + blk_sync_queue(ctrl->admin_q);
> }
> EXPORT_SYMBOL_GPL(nvme_sync_queues);
>
> --
> 2.20.1
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nvme: include admin_q sync with nvme_sync_queues
2019-09-03 20:08 [PATCH] nvme: include admin_q sync with nvme_sync_queues Edmund Nadolski
2019-09-03 20:12 ` Keith Busch
@ 2019-09-03 20:22 ` James Smart
2019-09-05 2:28 ` Sagi Grimberg
2019-09-04 12:47 ` Christoph Hellwig
2 siblings, 1 reply; 5+ messages in thread
From: James Smart @ 2019-09-03 20:22 UTC (permalink / raw)
To: Edmund Nadolski, linux-nvme, keith.busch
On 9/3/2019 1:08 PM, Edmund Nadolski wrote:
> nvme_sync_queues currently syncs all namespace queues, but should
> also sync the admin queue, if present.
>
> Signed-off-by: Edmund Nadolski <edmund.nadolski@intel.com>
> ---
> drivers/nvme/host/core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 4660505eded9..43c12f8c030f 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -3974,6 +3974,9 @@ void nvme_sync_queues(struct nvme_ctrl *ctrl)
> list_for_each_entry(ns, &ctrl->namespaces, list)
> blk_sync_queue(ns->queue);
> up_read(&ctrl->namespaces_rwsem);
> +
> + if (ctrl->admin_q)
> + blk_sync_queue(ctrl->admin_q);
> }
> EXPORT_SYMBOL_GPL(nvme_sync_queues);
>
which probably mean the new request_q should be there too....
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nvme: include admin_q sync with nvme_sync_queues
2019-09-03 20:08 [PATCH] nvme: include admin_q sync with nvme_sync_queues Edmund Nadolski
2019-09-03 20:12 ` Keith Busch
2019-09-03 20:22 ` James Smart
@ 2019-09-04 12:47 ` Christoph Hellwig
2 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2019-09-04 12:47 UTC (permalink / raw)
To: Edmund Nadolski; +Cc: keith.busch, linux-nvme
On Tue, Sep 03, 2019 at 02:08:47PM -0600, Edmund Nadolski wrote:
> nvme_sync_queues currently syncs all namespace queues, but should
> also sync the admin queue, if present.
>
> Signed-off-by: Edmund Nadolski <edmund.nadolski@intel.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nvme: include admin_q sync with nvme_sync_queues
2019-09-03 20:22 ` James Smart
@ 2019-09-05 2:28 ` Sagi Grimberg
0 siblings, 0 replies; 5+ messages in thread
From: Sagi Grimberg @ 2019-09-05 2:28 UTC (permalink / raw)
To: James Smart, Edmund Nadolski, linux-nvme, keith.busch
> On 9/3/2019 1:08 PM, Edmund Nadolski wrote:
>> nvme_sync_queues currently syncs all namespace queues, but should
>> also sync the admin queue, if present.
>>
>> Signed-off-by: Edmund Nadolski <edmund.nadolski@intel.com>
>> ---
>> drivers/nvme/host/core.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
>> index 4660505eded9..43c12f8c030f 100644
>> --- a/drivers/nvme/host/core.c
>> +++ b/drivers/nvme/host/core.c
>> @@ -3974,6 +3974,9 @@ void nvme_sync_queues(struct nvme_ctrl *ctrl)
>> list_for_each_entry(ns, &ctrl->namespaces, list)
>> blk_sync_queue(ns->queue);
>> up_read(&ctrl->namespaces_rwsem);
>> +
>> + if (ctrl->admin_q)
>> + blk_sync_queue(ctrl->admin_q);
>> }
>> EXPORT_SYMBOL_GPL(nvme_sync_queues);
> which probably mean the new request_q should be there too....
Given that only pci uses it I think we don't need it for now...
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-09-05 2:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-03 20:08 [PATCH] nvme: include admin_q sync with nvme_sync_queues Edmund Nadolski
2019-09-03 20:12 ` Keith Busch
2019-09-03 20:22 ` James Smart
2019-09-05 2:28 ` Sagi Grimberg
2019-09-04 12:47 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).