From: Keith Busch <kbusch@kernel.org>
To: Israel Rukshin <israelr@mellanox.com>
Cc: Max Gurtovoy <maxg@mellanox.com>, Christoph Hellwig <hch@lst.de>,
Linux-nvme <linux-nvme@lists.infradead.org>,
Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH] nvme: Remove double assignment of cq vector
Date: Thu, 5 Sep 2019 08:59:38 -0600 [thread overview]
Message-ID: <20190905145937.GB24939@localhost.localdomain> (raw)
In-Reply-To: <1567695048-5234-1-git-send-email-israelr@mellanox.com>
On Thu, Sep 05, 2019 at 02:50:48PM +0000, Israel Rukshin wrote:
> Poll queues don't use it, so the assignment should be only when
> using IRQs.
It's not really a double assignment. An interrupt driven queue may become
a polled queue after a reset, in which case this assignment serves to
clear it's previously assigned vector. It doesn't actually appear to
matter if we've cleared it or not when the NVMEQ_POLLED flag is set,
though.
> Signed-off-by: Israel Rukshin <israelr@mellanox.com>
> Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
> ---
> drivers/nvme/host/pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 10d3071d6098..492074c95b9b 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -1560,7 +1560,6 @@ static int nvme_create_queue(struct nvme_queue *nvmeq, int qid, bool polled)
> else if (result)
> goto release_cq;
>
> - nvmeq->cq_vector = vector;
> nvme_init_queue(nvmeq, qid);
>
> if (!polled) {
> --
> 2.16.3
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-09-05 15:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 14:50 [PATCH] nvme: Remove double assignment of cq vector Israel Rukshin
2019-09-05 14:59 ` Keith Busch [this message]
2019-09-05 15:10 ` Israel Rukshin
2019-09-05 15:21 ` Keith Busch
2019-09-05 15:22 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905145937.GB24939@localhost.localdomain \
--to=kbusch@kernel.org \
--cc=hch@lst.de \
--cc=israelr@mellanox.com \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).